Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove duplicate indentwith in clang-format #48834

Merged
merged 1 commit into from
Apr 21, 2023
Merged

remove duplicate indentwith in clang-format #48834

merged 1 commit into from
Apr 21, 2023

Conversation

infdahai
Copy link
Contributor

@infdahai infdahai commented Apr 17, 2023 •
edited

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

The key IndentWidth appears twice in the .clang-format. so I remove it once.

@CLAassistant
Copy link

CLAassistant commented Apr 17, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Apr 17, 2023
@CheSema CheSema added the can be tested Allows running workflows for external contributors label Apr 17, 2023
@CheSema CheSema self-assigned this Apr 17, 2023
@infdahai infdahai force-pushed the infdahai-IndentWidth branch 2 times, most recently from 3785bef to a0ce24c Compare April 18, 2023 05:17
@infdahai
remove duplicate indentwith
a123250 
IndentWidth key shoudle be unique
@CheSema
Copy link
Member

CheSema commented Apr 21, 2023

test_odbc_interaction/test.py::test_many_connections
test_odbc_interaction/test.py:: test_concurrent_queries

flaks
https://play.clickhouse.com/play?user=play#c2VsZWN0IAp0b1N0YXJ0T2ZIb3VyKGNoZWNrX3N0YXJ0X3RpbWUpIGFzIGQsCmNvdW50KCksICBncm91cFVuaXFBcnJheShwdWxsX3JlcXVlc3RfbnVtYmVyKSwgIGFueShyZXBvcnRfdXJsKQpmcm9tIGNoZWNrcyB3aGVyZSAnMjAyMi0wNi0wMScgPD0gY2hlY2tfc3RhcnRfdGltZSBhbmQgdGVzdF9uYW1lIGxpa2UgJyV0ZXN0X29kYmNfaW50ZXJhY3Rpb24lJyBhbmQgdGVzdF9zdGF0dXMgaW4gKCdGQUlMJywgJ0ZMQUtZJykgZ3JvdXAgYnkgZCBvcmRlciBieSBkIGRlc2M=

@CheSema CheSema merged commit c5f5725 into ClickHouse:master Apr 21, 2023
136 of 137 checks passed
@infdahai infdahai deleted the infdahai-IndentWidth branch April 21, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheSema CheSema CheSema approved these changes

Assignees

@CheSema CheSema

Labels
can be tested Allows running workflows for external contributors pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@infdahai @CLAassistant @CheSema @robot-clickhouse-ci-2