Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add aliases for parts name and names #48850

Merged
merged 2 commits into from
Apr 20, 2023
Merged

add aliases for parts name and names #48850

merged 2 commits into from
Apr 20, 2023

Conversation

sichenzhao
Copy link
Contributor

@sichenzhao sichenzhao commented Apr 17, 2023 •
edited by KochetovNicolai

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add aliases name and part_name form system.parts and system.part_log. Closes #48718

@CLAassistant
Copy link

CLAassistant commented Apr 17, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@sichenzhao
Copy link
Contributor Author

image

image

@KochetovNicolai KochetovNicolai added the pr-improvement Pull request with some product improvements label Apr 17, 2023
@thevar1able thevar1able added the can be tested Allows running workflows for external contributors label Apr 17, 2023
@hanfei1991 hanfei1991 self-assigned this Apr 17, 2023
hanfei1991
hanfei1991 approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@hanfei1991 hanfei1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but I think this change is very simple, so it's also okay to not add a test

@hanfei1991
Copy link
Member

@sichenzhao test fails ...

@hanfei1991 hanfei1991 merged commit 6805edf into ClickHouse:master Apr 20, 2023
137 checks passed
@alexey-milovidov alexey-milovidov mentioned this pull request Aug 20, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanfei1991 hanfei1991 hanfei1991 approved these changes

Assignees

@hanfei1991 hanfei1991

Labels
can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alias part and part_name for system.part_log and system.parts
5 participants
@sichenzhao @CLAassistant @hanfei1991 @thevar1able @KochetovNicolai