Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client: disable indent_multiline mode for Replxx history #48870

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

jh0x
Copy link
Contributor

@jh0x jh0x commented Apr 17, 2023

Fixes #48814

image

Should I make this option configurable?

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Multi-line history in clickhouse-client is now no longer padded. This makes pasting more natural.

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Apr 17, 2023
@nikitamikhaylov nikitamikhaylov added the can be tested Allows running workflows for external contributors label Apr 17, 2023
@rschu1ze
Copy link
Member

Thanks, that's a nice little PR - let me add a changelog entry so you get some credits :-) Errors look actually related but to be sure, I'll merge from master once more.

Should I make this option configurable?

For simplicity, I don't think that's necessary.

@rschu1ze rschu1ze self-assigned this Apr 18, 2023
@robot-ch-test-poll robot-ch-test-poll added pr-improvement Pull request with some product improvements and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Apr 18, 2023
@rschu1ze rschu1ze merged commit 2b5a129 into ClickHouse:master Apr 19, 2023
136 of 137 checks passed
@jh0x jh0x deleted the improve-client-history-indent branch April 20, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I'd prefer to not have extra padding for queries from history in clickhouse-client
5 participants