Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order by in test_storage_delta #48903

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Conversation

vdimir
Copy link
Member

@vdimir vdimir commented Apr 18, 2023

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Sometimes a bit flaky: https://s3.amazonaws.com/clickhouse-test-reports/0/799e0535a9439f57c9d7979bf2ae0ebba2b978f4/integration_tests__release__[3/4]/integration_run_parallel3_0.log

explain plan
SELECT number, toString(number + 1) FROM numbers(5)
UNION ALL SELECT number, toString(number + 1) FROM numbers(10, 15)
ORDER BY 1;

┌─explain────────────────────────────────────────────────────────┐
│ Union                                                          │
│   Expression ((Projection + Before ORDER BY))                  │
│     ReadFromStorage (SystemNumbers)                            │
│   Expression ((Projection + Before ORDER BY [lifted up part])) │
│     Sorting (Sorting for ORDER BY)                             │
│       Expression (Before ORDER BY)                             │
│         ReadFromStorage (SystemNumbers)                        │
└────────────────────────────────────────────────────────────────┘


explain plan
SELECT * FROM (
    SELECT number, toString(number + 1) FROM numbers(5)
    UNION ALL SELECT number, toString(number + 1) FROM numbers(10, 15)
) ORDER BY 1;

┌─explain───────────────────────────────────────────────────────────────┐
│ Expression (Projection)                                               │
│   Sorting (Sorting for ORDER BY)                                      │
│     Union                                                             │
│       Expression ((Before ORDER BY + (Projection + Before ORDER BY))) │
│         ReadFromStorage (SystemNumbers)                               │
│       Expression (( + (Projection + Before ORDER BY)))                │
│         ReadFromStorage (SystemNumbers)                               │
└───────────────────────────────────────────────────────────────────────┘

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Apr 18, 2023
@kssenii
Copy link
Member

kssenii commented Apr 19, 2023

Integration tests flaky check (asan) — Empty test_results.tsv

Can't start docker daemon, timeout exceeded.

@kssenii kssenii merged commit 6843874 into master Apr 19, 2023
124 of 140 checks passed
@kssenii kssenii deleted the vdimir/fix_test_storage_delta branch April 19, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants