Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfault when set is not built yet #48904

Merged
merged 3 commits into from
Apr 21, 2023

Conversation

davenger
Copy link
Member

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Apr 18, 2023
Copy link
Member

@vdimir vdimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And what about

auto set = column_set->getData();
auto set_types = set->getDataTypes();

if (column_set->getData()->isCreated() && column_set->getData()->getTotalRowCount() == 0)
return true;

do we need to check also there or at any other similar places were getData is used?

@vdimir vdimir self-assigned this Apr 18, 2023
@davenger
Copy link
Member Author

Yes.
I've added the checks

@alexey-milovidov alexey-milovidov merged commit bd64a4a into master Apr 21, 2023
140 checks passed
@alexey-milovidov alexey-milovidov deleted the fix_set_withzk_and_analyzer branch April 21, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants