Add fallback to password auth after failed SSL auth #48989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse-ci-2
added
the
pr-improvement
evillique
changed the title
|
Converted to draft before the changelog entry will be filled. |
|
Missing test. |
evillique
commented
Apr 21, 2023
| assert "UNKNOWN_CA" in str(err.value) | ||
|
|
||
|
|
||
| def test_native_fallback_to_password(): |
There was a problem hiding this comment.
Reeordered things a bit, the new test is here
alexey-milovidov
approved these changes
Apr 21, 2023
robot-clickhouse
added a commit
that referenced
this pull request
Apr 21, 2023
robot-ch-test-poll4
added
the
pr-backports-created
evillique
added a commit
that referenced
this pull request
Apr 22, 2023
Backport #48989 to 23.3: Add fallback to password auth after failed SSL auth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add fallback to password authentication when authentication with SSL user certificate has failed. Closes #48974