Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grace hash join supports right/full join #49483

Merged
merged 15 commits into from
May 22, 2023

Conversation

lgbo-ustc
Copy link
Contributor

@lgbo-ustc lgbo-ustc commented May 4, 2023

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Support full/right join by using grace hash join algorithm.

fixes: #48546

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-clickhouse robot-clickhouse added the pr-feature Pull request with new product feature label May 4, 2023
@robot-clickhouse
Copy link
Member

robot-clickhouse commented May 4, 2023

This is an automated comment for commit cc93f9a with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Docs CheckBuilds and tests the documentation🟡 pending
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🔴 failure
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🔴 failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@lgbo-ustc lgbo-ustc force-pushed the grace_hash_full_join branch 3 times, most recently from e6b445c to 35ba37b Compare May 4, 2023 02:44
@lgbo-ustc lgbo-ustc marked this pull request as ready for review May 4, 2023 03:21
@lgbo-ustc lgbo-ustc force-pushed the grace_hash_full_join branch 2 times, most recently from 9a63715 to 31d9d4b Compare May 4, 2023 08:46
@nickitat nickitat added the can be tested Allows running workflows for external contributors label May 4, 2023
@lgbo-ustc lgbo-ustc force-pushed the grace_hash_full_join branch 13 times, most recently from 1298d88 to 741fa32 Compare May 9, 2023 03:52
@lgbo-ustc
Copy link
Contributor Author

lgbo-ustc commented May 10, 2023

There are still two bugs to be fixed which may be some compatibility issues

@lgbo-ustc
Copy link
Contributor Author

lgbo-ustc commented May 10, 2023

@vdimir Is there any way to skip the test for grace_hash in the flaky tests. It's too slow with small max_block_size and hash join size limit.

@lgbo-ustc lgbo-ustc requested a review from vdimir May 10, 2023 08:19
@vdimir vdimir self-assigned this May 10, 2023
src/Interpreters/GraceHashJoin.cpp Show resolved Hide resolved
@vdimir vdimir added the skip mergeable check The label to omit checks for required statuses. Does not help with `pr-feature` new docs check label May 17, 2023
@vdimir
Copy link
Member

vdimir commented May 17, 2023

Could you rebase branch one more time please, Mergeable Check is blocked due to broken Unit tests (asan) — PASSED record not found in master

@lgbo-ustc
Copy link
Contributor Author

Could you rebase branch one more time please, Mergeable Check is blocked due to broken Unit tests (asan) — PASSED record not found in master

done

@vdimir vdimir removed the skip mergeable check The label to omit checks for required statuses. Does not help with `pr-feature` new docs check label May 22, 2023
@vdimir vdimir merged commit fa93c38 into ClickHouse:master May 22, 2023
258 of 265 checks passed
@vdimir
Copy link
Member

vdimir commented May 31, 2023

@lgbo-ustc
Can it be related? Logical error appeared due to race #50220
It's suspicious, but I don't see how the change could affect, though.

@lgbo-ustc
Copy link
Contributor Author

@lgbo-ustc Can it be related? Logical error appeared due to race #50220 It's suspicious, but I don't see how the change could affect, though.

I‘m looking into it. But I guess the modification only affects the delayed phase and the exception happened in filling right side phase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-feature Pull request with new product feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support FULL join with grace_hash join
4 participants