New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Revert "groupArray
returns cannot be nullable"
#49971
Merged
alexey-milovidov
merged 1 commit into
ClickHouse:master
from
azat:revert-48593-group_array_nullable
May 18, 2023
Merged
[RFC] Revert "groupArray
returns cannot be nullable"
#49971
alexey-milovidov
merged 1 commit into
ClickHouse:master
from
azat:revert-48593-group_array_nullable
May 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll2
added
the
pr-backward-incompatible
Pull request with backwards incompatible changes
label
May 17, 2023
This is an automated comment for commit e2e3a03 with description of existing statuses. It's updated for the latest CI running
|
alexey-milovidov
added
the
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
label
May 18, 2023
This was referenced May 18, 2023
robot-clickhouse
added a commit
that referenced
this pull request
May 18, 2023
robot-clickhouse
added a commit
that referenced
this pull request
May 18, 2023
robot-clickhouse
added a commit
that referenced
this pull request
May 18, 2023
robot-ch-test-poll3
added
the
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
label
May 18, 2023
alexey-milovidov
added a commit
that referenced
this pull request
May 21, 2023
Backport #49971 to 23.4: [RFC] Revert "`groupArray` returns cannot be nullable"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-backward-incompatible
Pull request with backwards incompatible changes
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Revert "
groupArray
returns cannot be nullable" (due to binary compatibility breakage forgroupArray
/groupArrayLast
/groupArraySample
overNullable
types, which likely will lead toTOO_LARGE_ARRAY_SIZE
orCANNOT_READ_ALL_DATA
)This breaks the binary compatibility:
And after upgrading you will not be able to read the data that was written with previous versions, and you will get one of two errors:
TOO_LARGE_ARRAY_SIZE
CANNOT_READ_ALL_DATA
Reverts #48593 (cc @nickitat @lgbo-ustc)
Backport: 23.4