New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid deadlock when starting table in attach thread of ReplicatedMergeTree
#50026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
May 19, 2023
This is an automated comment for commit 4af8187 with description of existing statuses. It's updated for the latest CI running
|
tavplubix
reviewed
May 19, 2023
tavplubix
approved these changes
May 19, 2023
tavplubix
added
the
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
label
May 22, 2023
robot-clickhouse
added a commit
that referenced
this pull request
May 22, 2023
… thread of `ReplicatedMergeTree`
robot-clickhouse
added a commit
that referenced
this pull request
May 22, 2023
… thread of `ReplicatedMergeTree`
robot-clickhouse
added a commit
that referenced
this pull request
May 22, 2023
… thread of `ReplicatedMergeTree`
robot-ch-test-poll4
added
the
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
label
May 22, 2023
antonio2368
added a commit
that referenced
this pull request
May 23, 2023
Backport #50026 to 23.3: Avoid deadlock when starting table in attach thread of `ReplicatedMergeTree`
antonio2368
added a commit
that referenced
this pull request
May 23, 2023
Backport #50026 to 23.2: Avoid deadlock when starting table in attach thread of `ReplicatedMergeTree`
antonio2368
added a commit
that referenced
this pull request
May 23, 2023
Backport #50026 to 23.4: Avoid deadlock when starting table in attach thread of `ReplicatedMergeTree`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-backports-created-cloud
pr-bugfix
Pull request with bugfix, not backported by default
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-must-backport-cloud
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Avoid deadlock when starting
ReplicatedMergeTree
tables. Tables could end up in deadlock if background threadpool size was lower than the number of tables.Fix #49962
Documentation entry for user-facing changes