Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for IDisk in Keeper #50098

Merged
merged 39 commits into from
Jul 3, 2023
Merged

Support for IDisk in Keeper #50098

merged 39 commits into from
Jul 3, 2023

Conversation

antonio2368
Copy link
Member

@antonio2368 antonio2368 commented May 22, 2023

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add support for external disks in Keeper for storing snapshots and logs.

Continuation of #45884

  • possibility to define different disks for current and old logs
  • restrict current disk to local disk
  • try supporting snapshots with s3_plain (uses moveFile which is not supported by s3_plain disks)

Disks heavily depend on the Context which pulls huge amount of dependencies with it. To keep those dependencies at minimum, standalone Keeper will use a stripped-down Context with all the functions necessary for Disks.

Also, I explicitly added only Local disk and S3 disks (without cache) as a starting point. In future PRs we can try extending the support but I didn't see a reason to support all of the disks immediately because the benefits are questionable while I would need to add even more dependencies.

Docs: ClickHouse/clickhouse-docs#1206

cc @alesapin @kssenii (sanity check for the Disks part) @LiuYangkuan

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-not-for-changelog This PR should not be mentioned in the changelog label May 22, 2023
@robot-ch-test-poll3
Copy link
Contributor

robot-ch-test-poll3 commented May 22, 2023

This is an automated comment for commit eba60dd with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse Keeper JepsenThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🔴 failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@antonio2368 antonio2368 added the jepsen-test Need to test this PR with jepsen tests label May 22, 2023
@antonio2368 antonio2368 force-pushed the keeper-with-disks branch 2 times, most recently from f18c51c to 7811ff1 Compare May 24, 2023 13:43
@antonio2368
Copy link
Member Author

antonio2368 commented May 25, 2023

This PR added some optimizations for reading snapshot from file which obviously don't work for DiskS3 so I added back the old behaviour (keeping latest snapshot in memory) for disks that are not DiskLocal.

@antonio2368 antonio2368 marked this pull request as ready for review June 1, 2023 14:43
@robot-clickhouse robot-clickhouse added pr-improvement Pull request with some product improvements and removed pr-not-for-changelog This PR should not be mentioned in the changelog labels Jun 2, 2023
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the submodule changed At least one submodule changed in this PR. label Jun 14, 2023
@pufit pufit self-assigned this Jun 24, 2023
Copy link
Member

@pufit pufit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@robot-ch-test-poll3 robot-ch-test-poll3 removed the submodule changed At least one submodule changed in this PR. label Jun 30, 2023
@antonio2368 antonio2368 merged commit 50c1a7f into master Jul 3, 2023
258 of 259 checks passed
@antonio2368 antonio2368 deleted the keeper-with-disks branch July 3, 2023 07:11
@kssenii kssenii mentioned this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jepsen-test Need to test this PR with jepsen tests pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants