-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for IDisk
in Keeper
#50098
Support for IDisk
in Keeper
#50098
Conversation
This is an automated comment for commit eba60dd with description of existing statuses. It's updated for the latest CI running
|
f18c51c
to
7811ff1
Compare
7811ff1
to
092cf99
Compare
6a34ff6
to
0f73e90
Compare
This PR added some optimizations for reading snapshot from file which obviously don't work for |
0f73e90
to
99ffacd
Compare
99ffacd
to
f519aa4
Compare
03c4678
to
fbba85a
Compare
fbba85a
to
ad2b926
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add support for external disks in Keeper for storing snapshots and logs.
Continuation of #45884
s3_plain
(usesmoveFile
which is not supported bys3_plain
disks)Disks heavily depend on the
Context
which pulls huge amount of dependencies with it. To keep those dependencies at minimum, standalone Keeper will use a stripped-downContext
with all the functions necessary for Disks.Also, I explicitly added only Local disk and S3 disks (without cache) as a starting point. In future PRs we can try extending the support but I didn't see a reason to support all of the disks immediately because the benefits are questionable while I would need to add even more dependencies.
Docs: ClickHouse/clickhouse-docs#1206
cc @alesapin @kssenii (sanity check for the Disks part) @LiuYangkuan
Documentation entry for user-facing changes