-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc Annoy index improvements #50661
Conversation
This is an automated comment for commit 7745f7d with description of existing statuses. It's updated for the latest CI running
|
fda46cc
to
0da069c
Compare
ClickHouse Stateless Tests (debug) [4/5]:
ClickHouse Stateless Tests (msan) [3/6]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rschu1ze Please check the comments regarding the tests. It's up to you when address them, if at all
@devcrafter Very good comments, thanks. I'd look into them separately. For now, allow me to merge - someone is waiting for the updated docs and I don't want to point to an open PR. |
Just FYI: this PR has broken the build of the docs. I am going to try and fix the issue in a separate PR. |
@rschu1ze Please add me as a reviewer to follow-up PRs |
No hassle at all...happy to fix it. Docusaurus uses React and it gets confused when it sees something like |
A mixed bag of fixes for Annoy:
GRANULARITY
-s.GRANULARITY
of Annoy indexes from 1 to 100 million rows. This is much closer to the behavior users intuitively expectChangelog category (leave one):