Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc Annoy index improvements #50661

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Misc Annoy index improvements #50661

merged 2 commits into from
Jun 12, 2023

Conversation

rschu1ze
Copy link
Member

@rschu1ze rschu1ze commented Jun 7, 2023

A mixed bag of fixes for Annoy:

  • tests:
    • added tests with different GRANULARITY-s.
    • re-enabled tests which were disabled (Temporarily disable annoy index tests (flaky for analyzer) #50714) due to flakiness in analyzer tests
    • commented out tests with unstable results. This was caused by the inherent randomness of Annoy search. They are useful anyways, so don't remove them completely.
  • much more extensive docs
  • changed the default GRANULARITY of Annoy indexes from 1 to 100 million rows. This is much closer to the behavior users intuitively expect

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jun 7, 2023
@robot-clickhouse-ci-2
Copy link
Contributor

robot-clickhouse-ci-2 commented Jun 7, 2023

This is an automated comment for commit 7745f7d with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟡 pending

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success

@rschu1ze rschu1ze force-pushed the annoy-misc branch 2 times, most recently from fda46cc to 0da069c Compare June 8, 2023 09:05
@rschu1ze rschu1ze changed the title (do not merge/review) Misc Annoy index improvements Misc Annoy index improvements Jun 8, 2023
@rschu1ze
Copy link
Member Author

rschu1ze commented Jun 9, 2023

ClickHouse Stateless Tests (debug) [4/5]:

ClickHouse Stateless Tests (msan) [3/6]

@devcrafter devcrafter self-assigned this Jun 11, 2023
Copy link
Member

@devcrafter devcrafter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rschu1ze Please check the comments regarding the tests. It's up to you when address them, if at all

@rschu1ze
Copy link
Member Author

@devcrafter Very good comments, thanks. I'd look into them separately. For now, allow me to merge - someone is waiting for the updated docs and I don't want to point to an open PR.

@rschu1ze rschu1ze merged commit 33ab8ee into ClickHouse:master Jun 12, 2023
8 of 11 checks passed
@rfraposa
Copy link
Contributor

Just FYI: this PR has broken the build of the docs. I am going to try and fix the issue in a separate PR.

@devcrafter
Copy link
Member

@devcrafter Very good comments, thanks. I'd look into them separately. For now, allow me to merge - someone is waiting for the updated docs and I don't want to point to an open PR.

@rschu1ze Please add me as a reviewer to follow-up PRs

@rschu1ze
Copy link
Member Author

Just FYI: this PR has broken the build of the docs. I am going to try and fix the issue in a separate PR.

Sorry for the hassle (I was pretty sure that the docs check was green).

@rschu1ze Please add me as a reviewer to follow-up PRs

Will do, here is one: #50912 ... more are coming.

@rfraposa
Copy link
Contributor

rfraposa commented Jun 13, 2023

No hassle at all...happy to fix it. Docusaurus uses React and it gets confused when it sees something like <ann_index_name>. I just replaced the angle brackets with square brackets: #50942

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants