New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type of LDAP server params hash in cache entry #50865
Fix type of LDAP server params hash in cache entry #50865
Conversation
In 1ed7ad5, we switched from (`size_t`, usually 64bit) to SipHash (128bit) and forgot to change the type of the cache entry. This broke the caching of successful LDAP authentication requests (verification cooldown). Fixes ClickHouse#50864
f9e7889
to
c378c3f
Compare
This is an automated comment for commit 6201947 with description of existing statuses. It's updated for the latest CI running
|
Could you please sign the CLA? |
Thx, just signed the CLA again. I already did this morning, but somehow the status got lost 🤷♂️ |
@evillique The CI summary shows test failures but I don't see any in the Checks tab 🤔 |
As far as I see none of the failures in the CI are related to your changes, so will merge as soon as this run is finished :) |
Backport #50865 to 23.3: Fix type of LDAP server params hash in cache entry
Backport #50865 to 23.4: Fix type of LDAP server params hash in cache entry
Backport #50865 to 23.5: Fix type of LDAP server params hash in cache entry
…h in cache entry
In 1ed7ad5, we switched from boost (
size_t
, usually 64bit) to SipHash (128bit) and forgot to change the type of the cache entry. This broke the caching of successful LDAP authentication requests (verification cooldown).Fixes #50864
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix caching of successful LDAP authentication requests (verification cooldown)