Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests' docker containers #51180

Merged
merged 18 commits into from
Jun 30, 2023
Merged

Update tests' docker containers #51180

merged 18 commits into from
Jun 30, 2023

Conversation

Felixoid
Copy link
Member

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Update Ubuntu version in docker containers

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-build Pull request with build/testing/packaging improvement label Jun 20, 2023
@robot-clickhouse-ci-2
Copy link
Contributor

robot-clickhouse-ci-2 commented Jun 20, 2023

This is an automated comment for commit 3402628 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟢 success

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse Keeper JepsenThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@Felixoid
Copy link
Member Author

The issue with mysql-odbc is addressed by using the recent version. Now the integration tests with sanitizers are the issue.

@Felixoid Felixoid added the jepsen-test Need to test this PR with jepsen tests label Jun 21, 2023
@Felixoid Felixoid force-pushed the update-tests-docker branch 2 times, most recently from 95f9140 to e289520 Compare June 22, 2023 08:53
@Felixoid Felixoid force-pushed the update-tests-docker branch 2 times, most recently from 89b02bc to 06590a5 Compare June 27, 2023 16:02
Copy link
Member

@qoega qoega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked everything except cgroups v2 cpp code.

@Felixoid
Copy link
Member Author

I checked everything except cgroups v2 cpp code.

@serxa checked it in #51478

@Felixoid
Copy link
Member Author

Mark it as Draft to not have it merged silently at night

@Felixoid Felixoid marked this pull request as draft June 29, 2023 19:56
@Felixoid Felixoid marked this pull request as ready for review June 30, 2023 07:19
@alexey-milovidov alexey-milovidov merged commit 1e6f6b5 into master Jun 30, 2023
261 of 262 checks passed
@alexey-milovidov alexey-milovidov deleted the update-tests-docker branch June 30, 2023 08:25
@tavplubix
Copy link
Member

It breaks integration tests, let's revert

alexey-milovidov added a commit that referenced this pull request Jul 6, 2023
Backport #51561 to 22.8: Decoupled commits from #51180 for backports
alexey-milovidov added a commit that referenced this pull request Jul 6, 2023
Backport #51561 to 23.4: Decoupled commits from #51180 for backports
alexey-milovidov added a commit that referenced this pull request Jul 6, 2023
Backport #51561 to 23.5: Decoupled commits from #51180 for backports
alexey-milovidov added a commit that referenced this pull request Jul 6, 2023
Backport #51561 to 23.3: Decoupled commits from #51180 for backports
MyroTk pushed a commit to Altinity/ClickHouse that referenced this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jepsen-test Need to test this PR with jepsen tests pr-backports-created-cloud pr-build Pull request with build/testing/packaging improvement pr-must-backport-cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants