New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build artifact with sources with submodules in Darwin special build #51435
Conversation
This is an automated comment for commit f525f05 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
To reduce the size of the archive, we can additionally add this part to the workflow OR to the script https://github.com/ClickHouse/ClickHouse/blob/master/.github/workflows/pull_request.yml#L558-L564 |
It should be unnecessary. I try to fix tar |
Sparse checkout is exactly two times lighter. We should use it.
|
OK. I just don't understand where I should add this step. If you can patch this PR the way you want - you are welcome. |
Than should do the thing |
467 vs 870. Looks worth! |
Let's do it for both darwin builds and we're good to go! |
One should be enough |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're good to go after the green checks
It's very unfortunate that we didn't merge it yet |
…19f892023930745fd9651cfc4e0f9 Cherry pick #51435 to 23.7: Build artifact with sources with submodules in Darwin special build
…in Darwin special build
…19f892023930745fd9651cfc4e0f9 Cherry pick #51435 to 23.8: Build artifact with sources with submodules in Darwin special build
…in Darwin special build
…19f892023930745fd9651cfc4e0f9 Cherry pick #51435 to 23.9: Build artifact with sources with submodules in Darwin special build
…in Darwin special build
Backport #51435 to 23.7: Build artifact with sources with submodules in Darwin special build
Backport #51435 to 23.9: Build artifact with sources with submodules in Darwin special build
Backport #51435 to 23.8: Build artifact with sources with submodules in Darwin special build
…19f892023930745fd9651cfc4e0f9 Cherry pick #51435 to 23.3: Build artifact with sources with submodules in Darwin special build
…in Darwin special build
Backport #51435 to 23.3: Build artifact with sources with submodules in Darwin special build
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Resource with source code including submodules is built in Darwin special build task. It may be used to build ClickHouse without checkouting submodules.
Documentation entry for user-facing changes