Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build artifact with sources with submodules in Darwin special build #51435

Merged
merged 6 commits into from Oct 7, 2023

Conversation

qoega
Copy link
Member

@qoega qoega commented Jun 26, 2023

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Resource with source code including submodules is built in Darwin special build task. It may be used to build ClickHouse without checkouting submodules.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-ch-test-poll robot-ch-test-poll added the pr-build Pull request with build/testing/packaging improvement label Jun 26, 2023
@robot-ch-test-poll
Copy link
Contributor

robot-ch-test-poll commented Jun 26, 2023

This is an automated comment for commit f525f05 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure

docker/packager/binary/build.sh Show resolved Hide resolved
docker/packager/packager Show resolved Hide resolved
@Felixoid Felixoid self-assigned this Jun 30, 2023
@Felixoid
Copy link
Member

To reduce the size of the archive, we can additionally add this part to the workflow OR to the script https://github.com/ClickHouse/ClickHouse/blob/master/.github/workflows/pull_request.yml#L558-L564

@qoega
Copy link
Member Author

qoega commented Jun 30, 2023

To reduce the size of the archive, we can additionally add this part to the workflow OR to the script https://github.com/ClickHouse/ClickHouse/blob/master/.github/workflows/pull_request.yml#L558-L564

It should be unnecessary. I try to fix tar --exclude filters and not include any .git files or similar. Only one version so this change is unnecessary to minimise tar size.

@Felixoid
Copy link
Member

Felixoid commented Jul 3, 2023

> ls /tmp/source_sub* -l
-rw-r--r-- 1 felixoid felixoid 380849752 Jul  3 16:47 /tmp/source_sub_sparsed.tar.gz
-rw-r--r-- 1 felixoid felixoid 283703728 Jul  3 17:01 /tmp/source_sub_sparsed.tar.xz
-rw-r--r-- 1 felixoid felixoid 370023959 Jul  3 17:02 /tmp/source_sub_sparsed.tar.zst
-rw-r--r-- 1 felixoid felixoid 791041769 Jul  3 15:37 /tmp/source_sub.tar.gz
-rw-r--r-- 1 felixoid felixoid 508762888 Jul  3 16:01 /tmp/source_sub.tar.xz
-rw-r--r-- 1 felixoid felixoid 715459283 Jul  3 16:43 /tmp/source_sub.tar.zst

Sparse checkout is exactly two times lighter. We should use it.

xz is a quite long on my laptop. I think, gz looks OK here

@qoega
Copy link
Member Author

qoega commented Jul 6, 2023

Sparse checkout is exactly two times lighter. We should use it.

OK. I just don't understand where I should add this step. If you can patch this PR the way you want - you are welcome.

@Felixoid
Copy link
Member

Felixoid commented Jul 6, 2023

Than should do the thing

@Felixoid
Copy link
Member

Felixoid commented Jul 6, 2023

467 vs 870. Looks worth!

@Felixoid
Copy link
Member

Let's do it for both darwin builds and we're good to go!

@qoega
Copy link
Member Author

qoega commented Jul 10, 2023

One should be enough

Copy link
Member

@Felixoid Felixoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're good to go after the green checks

@Felixoid
Copy link
Member

Felixoid commented Oct 3, 2023

It's very unfortunate that we didn't merge it yet

@Felixoid Felixoid added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Oct 3, 2023
@qoega qoega merged commit 262373c into ClickHouse:master Oct 7, 2023
272 of 274 checks passed
robot-ch-test-poll2 added a commit that referenced this pull request Oct 7, 2023
…19f892023930745fd9651cfc4e0f9

Cherry pick #51435 to 23.7: Build artifact with sources with submodules in Darwin special build
robot-clickhouse added a commit that referenced this pull request Oct 7, 2023
robot-ch-test-poll2 added a commit that referenced this pull request Oct 7, 2023
…19f892023930745fd9651cfc4e0f9

Cherry pick #51435 to 23.8: Build artifact with sources with submodules in Darwin special build
robot-clickhouse added a commit that referenced this pull request Oct 7, 2023
robot-ch-test-poll2 added a commit that referenced this pull request Oct 7, 2023
…19f892023930745fd9651cfc4e0f9

Cherry pick #51435 to 23.9: Build artifact with sources with submodules in Darwin special build
robot-clickhouse added a commit that referenced this pull request Oct 7, 2023
alexey-milovidov added a commit that referenced this pull request Oct 7, 2023
Backport #51435 to 23.7: Build artifact with sources with submodules in Darwin special build
alexey-milovidov added a commit that referenced this pull request Oct 7, 2023
Backport #51435 to 23.9: Build artifact with sources with submodules in Darwin special build
alexey-milovidov added a commit that referenced this pull request Oct 7, 2023
Backport #51435 to 23.8: Build artifact with sources with submodules in Darwin special build
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Oct 7, 2023
@Felixoid Felixoid removed the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Oct 9, 2023
robot-ch-test-poll1 added a commit that referenced this pull request Oct 9, 2023
…19f892023930745fd9651cfc4e0f9

Cherry pick #51435 to 23.3: Build artifact with sources with submodules in Darwin special build
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Oct 9, 2023
robot-clickhouse added a commit that referenced this pull request Oct 9, 2023
alexey-milovidov added a commit that referenced this pull request Oct 9, 2023
Backport #51435 to 23.3: Build artifact with sources with submodules in Darwin special build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-build Pull request with build/testing/packaging improvement pr-must-backport Pull request should be backported intentionally. Use this label with great care!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants