-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Cleanup remote_servers in dist config.xml #51985
[RFC] Cleanup remote_servers in dist config.xml #51985
Conversation
This is an automated comment for commit 2db092f with description of existing statuses. It's updated for the latest CI running
|
Let's add this: #51210 |
Maybe go further and remove all other clusters as well? |
ef53c2f
to
86455a0
Compare
Yes, let's do this as well. |
86455a0
to
f45d53c
Compare
At first, there was no such amount of clusters in dist config, they added when someone need to write some new cluster for tests. So let's move them to the clusters.xml that is deployed only for tests, and leave only default cluster. And cleanup also some configs that had been copied from dist config in the repo (about test_config_* integration tests, this should be OK, since there are more_clusters.xml as well, that covers additional cases). Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
f45d53c
to
2db092f
Compare
Does not looks related:
|
At first, there was no such amount of clusters in dist config, they added when someone need to write some new cluster for tests.
So let's move them to the clusters.xml that is deployed only for tests, and leave only default cluster.
And cleanup also some configs that had been copied from dist config in the repo (about test_config_* integration tests, this should be OK, since there are more_clusters.xml as well, that covers additional cases).
Changelog category (leave one):
Fixes: #51210