Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Cleanup remote_servers in dist config.xml #51985

Merged
merged 1 commit into from
Jul 9, 2023

Conversation

azat
Copy link
Collaborator

@azat azat commented Jul 8, 2023

At first, there was no such amount of clusters in dist config, they added when someone need to write some new cluster for tests.

So let's move them to the clusters.xml that is deployed only for tests, and leave only default cluster.

And cleanup also some configs that had been copied from dist config in the repo (about test_config_* integration tests, this should be OK, since there are more_clusters.xml as well, that covers additional cases).

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Fixes: #51210

@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 8, 2023
@robot-ch-test-poll4
Copy link
Contributor

robot-ch-test-poll4 commented Jul 8, 2023

This is an automated comment for commit 2db092f with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟢 success

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@alexey-milovidov
Copy link
Member

Let's add this: #51210

@alexey-milovidov
Copy link
Member

Maybe go further and remove all other clusters as well?

@azat
Copy link
Collaborator Author

azat commented Jul 9, 2023

Maybe go further and remove all other clusters as well?

Yes, let's do this as well.

At first, there was no such amount of clusters in dist config, they
added when someone need to write some new cluster for tests.

So let's move them to the clusters.xml that is deployed only for tests,
and leave only default cluster.

And cleanup also some configs that had been copied from dist config in
the repo (about test_config_* integration tests, this should be OK,
since there are more_clusters.xml as well, that covers additional
cases).

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
@azat
Copy link
Collaborator Author

azat commented Jul 9, 2023

Does not looks related:

PullRequestCI / SQLLogicTestRelease (pull_request) Failing after 6m

+ /clickhouse-tests/sqllogic/runner.py --log-file /test_output/runner-statements-test.log --log-level info statements-test --input-dir /sqllogictest --out-dir /test_output/statements-test
+ ts '%Y-%m-%d %H:%M:%S'
2023-07-09 18:02:26 multiprocessing.pool.RemoteTraceback: 
2023-07-09 18:02:26 """
2023-07-09 18:02:26 Traceback (most recent call last):
2023-07-09 18:02:26   File "/usr/lib/python3.10/multiprocessing/pool.py", line 125, in worker
2023-07-09 18:02:26     result = (True, func(*args, **kwds))
2023-07-09 18:02:26   File "/clickhouse-tests/sqllogic/runner.py", line 135, in _child_process
2023-07-09 18:02:26     runner.run_all_tests_from_file(test, input_dir)
2023-07-09 18:02:26   File "/clickhouse-tests/sqllogic/test_runner.py", line 557, in run_all_tests_from_file
2023-07-09 18:02:26     self.run_one_test(stream, test_name, test_file)
2023-07-09 18:02:26   File "/clickhouse-tests/sqllogic/test_runner.py", line 532, in run_one_test
2023-07-09 18:02:26     with self.connection.with_one_test_scope():
2023-07-09 18:02:26   File "/usr/lib/python3.10/contextlib.py", line 142, in __exit__
2023-07-09 18:02:26     next(self.gen)
2023-07-09 18:02:26   File "/clickhouse-tests/sqllogic/connection.py", line 164, in with_one_test_scope
2023-07-09 18:02:26     self.drop_all_tables()
2023-07-09 18:02:26   File "/clickhouse-tests/sqllogic/connection.py", line 136, in drop_all_tables
2023-07-09 18:02:26     logger.info("tables will be dropped: %s", list_result.get_result())
2023-07-09 18:02:26   File "/clickhouse-tests/sqllogic/connection.py", line 241, in get_result
2023-07-09 18:02:26     self.assert_no_exception()
2023-07-09 18:02:26   File "/clickhouse-tests/sqllogic/connection.py", line 264, in assert_no_exception
2023-07-09 18:02:26     raise ProgramError(
2023-07-09 18:02:26 exceptions.ProgramError: request doesn't have a result set, it has the exception, exception: ('HY000', '[HY000] HTTP status code: 500\nReceived error:\nCode: 373. DB::Exception: Session clickhouse_odbc_9370860175744060927 is locked by a concurrent client. (SESSION_IS_LOCKED) (version 23.7.1.824)\n\n (1) (SQLExecDirectW)')
2023-07-09 18:02:26 """
2023-07-09 18:02:26 
2023-07-09 18:02:26 The above exception was the direct cause of the following exception:
2023-07-09 18:02:26 
2023-07-09 18:02:26 Traceback (most recent call last):
2023-07-09 18:02:26   File "/clickhouse-tests/sqllogic/runner.py", line 428, in <module>
2023-07-09 18:02:26     main()
2023-07-09 18:02:26   File "/clickhouse-tests/sqllogic/runner.py", line 424, in main
2023-07-09 18:02:26     args.func(args)
2023-07-09 18:02:26   File "/clickhouse-tests/sqllogic/runner.py", line 208, in calle
2023-07-09 18:02:26     reports["verify-clickhouse"] = run_all_tests_in_parallel(
2023-07-09 18:02:26   File "/clickhouse-tests/sqllogic/runner.py", line 156, in run_all_tests_in_parallel
2023-07-09 18:02:26     reports = [ar.get() for ar in async_results]
2023-07-09 18:02:26   File "/clickhouse-tests/sqllogic/runner.py", line 156, in <listcomp>
2023-07-09 18:02:26     reports = [ar.get() for ar in async_results]
2023-07-09 18:02:26   File "/usr/lib/python3.10/multiprocessing/pool.py", line 774, in get
2023-07-09 18:02:26     raise self._value
2023-07-09 18:02:26 exceptions.ProgramError: request doesn't have a result set, it has the exception, exception: ('HY000', '[HY000] HTTP status code: 500\nReceived error:\nCode: 373. DB::Exception: Session clickhouse_odbc_9370860175744060927 is locked by a concurrent client. (SESSION_IS_LOCKED) (version 23.7.1.824)\n\n (1) (SQLExecDirectW)')

@alexey-milovidov alexey-milovidov self-assigned this Jul 9, 2023
@alexey-milovidov alexey-milovidov merged commit dd1c528 into ClickHouse:master Jul 9, 2023
259 of 260 checks passed
@azat azat deleted the cleanup-remote-servers branch July 10, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
3 participants