New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lightweight delete after drop of projection #52517
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse-ci-1
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Jul 24, 2023
This is an automated comment for commit 45542fd with description of existing statuses. It's updated for the latest CI running
|
davenger
reviewed
Jul 24, 2023
I also found that this sequence of queries fail on materialization of projection in an obscure way, but let's fix it in a separate PR: SET mutations_sync = 2;
CREATE TABLE t_projections_lwd (a UInt32, b UInt32, PROJECTION p ()) ENGINE = MergeTree;
INSERT INTO t_projections_lwd SELECT number, number FROM numbers(100);
-- LWD works
DELETE FROM t_projections_lwd WHERE a = 0;
-- add projection
ALTER TABLE t_projections_lwd ADD PROJECTION p_t_projections_lwd ();
ALTER TABLE t_projections_lwd MATERIALIZE PROJECTION p_t_projections_lwd; |
davenger
approved these changes
Jul 25, 2023
tavplubix
added
the
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
label
Aug 29, 2023
robot-clickhouse
added a commit
that referenced
this pull request
Aug 29, 2023
robot-clickhouse
added a commit
that referenced
this pull request
Aug 29, 2023
robot-clickhouse
added a commit
that referenced
this pull request
Aug 29, 2023
robot-ch-test-poll3
added
the
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
label
Aug 29, 2023
robot-clickhouse
added a commit
that referenced
this pull request
Aug 29, 2023
robot-ch-test-poll
added a commit
that referenced
this pull request
Oct 9, 2023
Backport #52517 to 23.3: Fix lightweight delete after drop of projection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-backports-created-cloud
pr-bugfix
Pull request with bugfix, not backported by default
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-must-backport-cloud
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix lightweight deletes after drop of projection. Lightweight deletes do not work in presence of projection but previously they could fail even after drop of projection.