Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lightweight delete after drop of projection #52517

Merged
merged 3 commits into from Jul 26, 2023

Conversation

CurtizJ
Copy link
Member

@CurtizJ CurtizJ commented Jul 24, 2023

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix lightweight deletes after drop of projection. Lightweight deletes do not work in presence of projection but previously they could fail even after drop of projection.

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-bugfix Pull request with bugfix, not backported by default label Jul 24, 2023
@robot-clickhouse-ci-1
Copy link
Contributor

robot-clickhouse-ci-1 commented Jul 24, 2023

This is an automated comment for commit 45542fd with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟡 pending

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟡 pending
Mergeable CheckChecks if all other necessary checks are successful🟢 success

@CurtizJ
Copy link
Member Author

CurtizJ commented Jul 25, 2023

I also found that this sequence of queries fail on materialization of projection in an obscure way, but let's fix it in a separate PR:

SET mutations_sync = 2;

CREATE TABLE t_projections_lwd (a UInt32, b UInt32, PROJECTION p ()) ENGINE = MergeTree;

INSERT INTO t_projections_lwd SELECT number, number FROM numbers(100);

-- LWD works
DELETE FROM t_projections_lwd WHERE a = 0;

-- add projection
ALTER TABLE t_projections_lwd ADD PROJECTION p_t_projections_lwd ();
ALTER TABLE t_projections_lwd MATERIALIZE PROJECTION p_t_projections_lwd;

@CurtizJ CurtizJ merged commit 77e645d into ClickHouse:master Jul 26, 2023
3 of 7 checks passed
@tavplubix tavplubix added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Aug 29, 2023
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Aug 29, 2023
robot-ch-test-poll added a commit that referenced this pull request Oct 9, 2023
Backport #52517 to 23.3: Fix lightweight delete after drop of projection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants