-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Significant improvement of rust caching #52865
Conversation
This is an automated comment for commit dcb1d3e with description of existing statuses. It's updated for the latest CI running
|
5a5e720
to
bcd3d10
Compare
Since there aren't objections, I am going to merge it after successful builds. |
The plan here is to implement the same scheme as it was for ccache, details are here #53060 (comment) |
bcd3d10
to
a3a671c
Compare
a7df94c
to
3a85a9d
Compare
3a85a9d
to
76d01bc
Compare
76d01bc
to
dcb1d3e
Compare
The implemented solution is much simpler than the previous one. The cargo cache is now stored in S3 in a single instance, and should be downloaded and uploaded much faster than previously. |
The tests must finish, there are many changes in global things like S3 and de-/compressing |
@azat I need assistant to backport it As far as I get, I need to remove existing Cargo.lock in subdirs, add the config https://github.com/ClickHouse/ClickHouse/blob/master/rust/Cargo.toml, and edit it accordingly to the repository state. What's then? invoke |
More or less, but there are some trickiness, see below.
Actually maybe the last command it extra and we need to pin the version, but let me take a look at it this separately, definitely it should not be a part of backports. |
thanks, but it's indeed too much work to try to backport it |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Follow-up for #52395. Cargo packages are now stored in S3 as a single archive per
rust/Cargo.lock
version. As well now rust is building with using of sccache.