Add backup_log system table

[sirvickr]

Closes #53221

Changelog category (leave one):

• New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Added a new system log table backup_log to track all BACKUP and RESTORE operations

Documentation entry for user-facing changes

• Documentation is written (mandatory for new features)

[sirvickr]

@vitlibar could you please take a look at this pull request?

[robot-clickhouse-ci-2]

This is an automated comment for commit 132ab60 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟢 success

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	🟢 success
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	🟢 success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	🟢 success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	🟢 success
Docker image for servers	The check to build and optionally push the mentioned image to docker hub	🟢 success
Docs Check	Builds and tests the documentation	🟢 success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	🟢 success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	🟢 success
Install packages	Checks that the built packages are installable in a clear environment	🟢 success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	🟢 success
Mergeable Check	Checks if all other necessary checks are successful	🟢 success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	🟢 success
Push to Dockerhub	The check for building and pushing the CI related docker images to docker hub	🟢 success
SQLTest	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	🟢 success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	🟢 success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	🟢 success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	🟢 success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	🟢 success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	🟢 success
Style Check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	🟢 success
Unit tests	Runs the unit tests for different release types	🟢 success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	🟢 success

[sirvickr]

Hello guys. I'm trying to figure out what's wrong with the CI jobs. Have they been cancelled manually or disrupted by some preceding failure?

[chhetripradeep]

You can try adding an empty commit to re-trigger the build.

[sirvickr]

Sure, thanks. I might as well merge master into my branch and thus re-launch the CI.
I was just wondering why the jobs are massively cancelled at times.

[rvasin]

Sure, thanks. I might as well merge master into my branch and thus re-launch the CI. I was just wondering why the jobs are massively cancelled at times.

Maybe it's some kind of a bug in CI. I hope someone from ClickHouse like @vitlibar will explain it.

[rvasin]

@vitlibar, could you please review this PR? Because @sirvickr is already working on the related task about system.backups persistence (see issue) and his new code is based on current PR.

So ideally it would be nice to merge the current PR to master at the end of this week. Then @sirvickr could create new PR about the system.backups persistence at the beginning or the middle of the next week.

[sirvickr]

@vitlibar, what do you think about this pull request? If you have any concerns or ideas, please feel free to share.

[vitlibar]

@vitlibar, what do you think about this pull request? If you have any concerns or ideas, please feel free to share.

No, let's wait until the checks are done and I will merge it.

[alexey-milovidov]

@sirvickr a bug has been found automatically: https://s3.amazonaws.com/clickhouse-test-reports/35961/c9753d7fd99050f0b6d4c4c5a02ab2c265239879/stateless_tests__tsan__[3_5]/stderr.log

[sirvickr]

Thank you, I'll take a close look.

[sirvickr]

I think I found the origin of the bug. The data race is possible due to the assignment of the backup_log member in the BackupsWorker::start() method which is called every time the query is executed within an arbitrary thread.
One of the possible decisions is to protect backup_log with a mutex but the whole decision to initialize it in the BackupsWorker::start() method looks like a bad idea.
The better decision would be to move its initialization to the BackupsWorker's constructor, just like this:

I'm going to double check everything locally and make a fixing PR ASAP.

[alexey-milovidov]

Thank you! Please do 🙏