Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #48998 to 23.3: Fix incorrect createColumn call on join clause #54424

Merged
merged 3 commits into from Oct 18, 2023

Conversation

robot-clickhouse
Copy link
Member

Original pull-request #48998
Cherry-pick pull-request #54423

This pull-request is a last step of an automated backporting.
Treat it as a standard pull-request: look at the checks and resolve conflicts.
Merge it only if you intend to backport changes to the target branch, otherwise just close it.

@robot-clickhouse robot-clickhouse added the pr-backport Changes, backported to release branch. Do not use manually - automated use only! label Sep 7, 2023
@robot-ch-test-poll4
Copy link
Contributor

robot-ch-test-poll4 commented Sep 7, 2023

This is an automated comment for commit 800d107 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success

@vdimir
Copy link
Member

vdimir commented Sep 8, 2023

ClickHouse special build check — 1/2 artifact groups are OK Details

Sep 07 16:44:01 -- Copy skim to /build/build_docker/rust/skim
Sep 07 16:44:01     Updating crates.io index
Sep 07 16:44:38 warning: spurious network error (3 tries remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
Sep 07 16:45:17 warning: spurious network error (2 tries remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
Sep 07 16:45:57 warning: spurious network error (1 tries remaining): [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
Sep 07 16:46:41 error: failed to get `syn` as a dependency of package `cxx-build v1.0.83`
Sep 07 16:46:41     ... which satisfies dependency `cxx-build = "^1.0.83"` (locked to 1.0.83) of package `_ch_rust_skim_rust v0.1.0 (/build/build_docker/rust/skim)`
Sep 07 16:46:41 
Sep 07 16:46:41 Caused by:
Sep 07 16:46:41   failed to query replaced source registry `crates-io`
Sep 07 16:46:41 
Sep 07 16:46:41 Caused by:
Sep 07 16:46:41   download of 3/s/syn failed
Sep 07 16:46:41 
Sep 07 16:46:41 Caused by:
Sep 07 16:46:41   failed to download from `https://index.crates.io/3/s/syn`
Sep 07 16:46:41 
Sep 07 16:46:41 Caused by:
Sep 07 16:46:41   [28] Timeout was reached (Operation too slow. Less than 10 bytes/sec transferred the last 30 seconds)
Sep 07 16:46:41 CMake Error at contrib/corrosion/cmake/CorrosionGenerator.cmake:10 (execute_process):
Sep 07 16:46:41   execute_process failed command indexes:
Sep 07 16:46:41 
Sep 07 16:46:41     1: "Child return code: 101"
Sep 07 16:46:41 
Sep 07 16:46:41 Call Stack (most recent call first):
Sep 07 16:46:41   contrib/corrosion/cmake/CorrosionGenerator.cmake:412 (_cargo_metadata)
Sep 07 16:46:41   contrib/corrosion/cmake/Corrosion.cmake:552 (_generator_add_cargo_targets)
Sep 07 16:46:41   rust/CMakeLists.txt:39 (corrosion_import_crate)
Sep 07 16:46:41   build_docker/rust/skim/CMakeLists.txt:17 (clickhouse_import_crate)

@robot-ch-test-poll4 robot-ch-test-poll4 merged commit 255c555 into 23.3 Oct 18, 2023
42 checks passed
@robot-ch-test-poll4 robot-ch-test-poll4 deleted the backport/23.3/48998 branch October 18, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backport Changes, backported to release branch. Do not use manually - automated use only!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants