New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update automated commit status comment #54441
Conversation
This is an automated comment for commit acb559c with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
d0dabbb
to
6a51d9f
Compare
Wow, it works! Wouldn't it be better if we put the status symbol in front of the title? |
Checked both options editing html in js console and setting random badges. |
I am afraid, it won't only affect the changes in the commit, but as well will terribly spoil the emails. The mailboxes will have up to 4 different threads (original, and 3 with different statuses), and it will be impossible to glue them together. It could look nice on the |
Let's check it |
bump |
@alexey-milovidov Vladimir and came to a model where we'd use only two statuses, red and green, and change them only back and forth as labels Changing labels are sent to all subscribers, so it's the best balance we could think of. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Mikhail f. Shiryaev <felixoid@clickhouse.com>
#54551 will address test_keeper_reconfig_remove_many/test.py::test_reconfig_remove_2_and_leader |
Backport #54441 to 23.8: Update automated commit status comment
Backport #54441 to 23.3: Update automated commit status comment
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Documentation entry for user-facing changes