Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update automated commit status comment #54441

Merged
merged 15 commits into from Sep 12, 2023
Merged

Conversation

vdimir
Copy link
Member

@vdimir vdimir commented Sep 8, 2023

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@vdimir vdimir mentioned this pull request Sep 8, 2023
42 tasks
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Sep 8, 2023
@robot-clickhouse-ci-1
Copy link
Contributor

robot-clickhouse-ci-1 commented Sep 8, 2023

This is an automated comment for commit acb559c with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure

@robot-ch-test-poll2 robot-ch-test-poll2 changed the title Update automated commit status comment Update automated commit status comment 🟡 Sep 8, 2023
@vdimir vdimir force-pushed the vdimir/ci-commit-statis-update branch from d0dabbb to 6a51d9f Compare September 8, 2023 17:05
@robot-ch-test-poll4 robot-ch-test-poll4 changed the title Update automated commit status comment 🟡 Update automated commit status comment 🔴 Sep 8, 2023
@alexey-milovidov
Copy link
Member

Wow, it works! Wouldn't it be better if we put the status symbol in front of the title?
(Easier to scan the list of pull requests).

@vdimir
Copy link
Member Author

vdimir commented Sep 11, 2023

@alexey-milovidov

Checked both options editing html in js console and setting random badges.
Badge in the beginning indeed looks better imo.

Screenshots Screenshot 2023-09-11 at 12 42 10
Screenshot 2023-09-11 at 12 42 20

@Felixoid
Copy link
Member

Won't it be TOO annoying to have these strings for every update?..

image

@Felixoid
Copy link
Member

I am afraid, it won't only affect the changes in the commit, but as well will terribly spoil the emails.

The mailboxes will have up to 4 different threads (original, and 3 with different statuses), and it will be impossible to glue them together. It could look nice on the pulls page, but has some drawbacks.

@vdimir
Copy link
Member Author

vdimir commented Sep 11, 2023

The mailboxes will have up to 4 different threads (original, and 3 with different statuses)

Let's check it

@vdimir vdimir changed the title Update automated commit status comment 🔴 Update automated commit status comment Sep 11, 2023
@robot-ch-test-poll robot-ch-test-poll changed the title Update automated commit status comment Update automated commit status comment 🟡 Sep 11, 2023
@vdimir
Copy link
Member Author

vdimir commented Sep 11, 2023

bump

@Felixoid
Copy link
Member

image

It looks strange..

@robot-ch-test-poll2 robot-ch-test-poll2 changed the title Update automated commit status comment 🟡 Update automated commit status comment 🟡 🟡 Sep 11, 2023
@robot-ch-test-poll2 robot-ch-test-poll2 changed the title Update automated commit status comment 🟡 🟡 Update automated commit status comment 🟡 🟡 🟡 Sep 11, 2023
@robot-ch-test-poll4 robot-ch-test-poll4 changed the title Update automated commit status comment 🟡 🟡 🟡 🟡 Update automated commit status comment 🟡 🟡 🟡 Sep 11, 2023
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 changed the title 🟡 Update automated commit status comment 🟡 🟡 🟡 🔴 Update automated commit status comment 🟡 🟡 🟡 Sep 11, 2023
@Felixoid
Copy link
Member

@alexey-milovidov Vladimir and came to a model where we'd use only two statuses, red and green, and change them only back and forth as labels pr-status-🟢 and pr-status-🔴

Changing labels are sent to all subscribers, so it's the best balance we could think of.

@Felixoid Felixoid changed the title 🔴 Update automated commit status comment 🟡 🟡 🟡 Update automated commit status comment Sep 11, 2023
@robot-clickhouse robot-clickhouse added pr-status-⏳ PR with some pending statuses and removed pr-status-❌ PR with some error/faliure statuses labels Sep 12, 2023
@Felixoid Felixoid added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Sep 12, 2023
Copy link
Member

@Felixoid Felixoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schitts Creek Perfect

@robot-ch-test-poll3 robot-ch-test-poll3 added pr-status-❌ PR with some error/faliure statuses and removed pr-status-⏳ PR with some pending statuses labels Sep 12, 2023
Co-authored-by: Mikhail f. Shiryaev <felixoid@clickhouse.com>
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added pr-status-⏳ PR with some pending statuses and removed pr-status-❌ PR with some error/faliure statuses labels Sep 12, 2023
@robot-ch-test-poll2 robot-ch-test-poll2 added pr-status-❌ PR with some error/faliure statuses and removed pr-status-⏳ PR with some pending statuses labels Sep 12, 2023
@Felixoid
Copy link
Member

#54551 will address test_keeper_reconfig_remove_many/test.py::test_reconfig_remove_2_and_leader

@Felixoid Felixoid merged commit 397a682 into master Sep 12, 2023
277 of 278 checks passed
@Felixoid Felixoid deleted the vdimir/ci-commit-statis-update branch September 12, 2023 19:18
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Sep 12, 2023
vdimir added a commit that referenced this pull request Sep 13, 2023
Backport #54441 to 23.8: Update automated commit status comment
vdimir added a commit that referenced this pull request Sep 13, 2023
Backport #54441 to 23.3: Update automated commit status comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-not-for-changelog This PR should not be mentioned in the changelog pr-status-❌ PR with some error/faliure statuses
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants