Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 artifacts #54504

Merged
merged 10 commits into from Sep 15, 2023
Merged

S3 artifacts #54504

merged 10 commits into from Sep 15, 2023

Conversation

Felixoid
Copy link
Member

@Felixoid Felixoid commented Sep 11, 2023

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Implement artifacts helper to handle lightweight files and directories in an easy way.

@Felixoid Felixoid added the do not test disable testing on pull request label Sep 11, 2023
@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Sep 11, 2023
@robot-clickhouse
Copy link
Member

robot-clickhouse commented Sep 11, 2023

This is an automated comment for commit 964b9ed with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure

@Felixoid Felixoid removed the do not test disable testing on pull request label Sep 12, 2023
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-status-⏳ PR with some pending statuses label Sep 12, 2023
@robot-ch-test-poll4 robot-ch-test-poll4 added pr-status-❌ PR with some error/faliure statuses and removed pr-status-⏳ PR with some pending statuses labels Sep 12, 2023
@robot-clickhouse robot-clickhouse added pr-status-⏳ PR with some pending statuses and removed pr-status-❌ PR with some error/faliure statuses labels Sep 12, 2023
@Felixoid Felixoid force-pushed the s3-artifacts branch 3 times, most recently from 793bb3d to 491a982 Compare September 13, 2023 22:33
@robot-ch-test-poll2 robot-ch-test-poll2 added pr-status-✅ PR with only success statuses and removed pr-status-⏳ PR with some pending statuses labels Sep 14, 2023
@robot-ch-test-poll4 robot-ch-test-poll4 added pr-status-⏳ PR with some pending statuses pr-status-❌ PR with some error/faliure statuses and removed pr-status-✅ PR with only success statuses pr-status-⏳ PR with some pending statuses labels Sep 14, 2023
@robot-ch-test-poll3 robot-ch-test-poll3 added pr-status-⏳ PR with some pending statuses and removed pr-status-❌ PR with some error/faliure statuses labels Sep 15, 2023
@Felixoid Felixoid marked this pull request as ready for review September 15, 2023 13:14
@Felixoid
Copy link
Member Author

All tests ran at least once, merging it to continue on the next week

@Felixoid Felixoid merged commit 4c9f8d1 into master Sep 15, 2023
243 of 259 checks passed
@Felixoid Felixoid deleted the s3-artifacts branch September 15, 2023 16:21
@Felixoid Felixoid added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Sep 15, 2023
@robot-ch-test-poll3 robot-ch-test-poll3 added pr-status-❌ PR with some error/faliure statuses and removed pr-status-⏳ PR with some pending statuses labels Sep 15, 2023
@Felixoid Felixoid removed the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Sep 15, 2023
@Felixoid Felixoid added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Sep 16, 2023
robot-clickhouse added a commit that referenced this pull request Sep 16, 2023
robot-clickhouse added a commit that referenced this pull request Sep 16, 2023
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Sep 16, 2023
Felixoid added a commit that referenced this pull request Sep 17, 2023
Felixoid added a commit that referenced this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-not-for-changelog This PR should not be mentioned in the changelog pr-status-❌ PR with some error/faliure statuses
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants