New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI skip build and skip tests checks #54532
Conversation
…tion_tests, can_skip_functional_tests checks in ci
This is an automated comment for commit c3f3824 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
tests/ci/pr_info.py
Outdated
for f in self.changed_files: | ||
# TODO: this logic is broken, should be fixed before using | ||
if not f.startswith("tests/integration") or not f.startswith( | ||
if not f.startswith("tests/integration") and not f.startswith( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it should be something more complex here.. We should check if the queries have changed. And split stateless and stateful tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, so if its not built again, then source is not changes . So we want to check if functional tests have been changed and if not we skip them.
and we don't want to check the tests/queries/bugs
folder ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I couldn't quickly find what's in the bugs
directory. According to git log
it's the temporary jail-directory for broken tests. So we need to track only 0_stateless 1_stateful
directories indeed
I'd suggest as well check some particular |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THanks a lot, let's merge it and move on!
The code is not active, so 100% didn't affect the tests |
…9aeb2138a5fa86fc54643e87496c1 Cherry pick #54532 to 23.3: Fix CI skip build and skip tests checks
…9aeb2138a5fa86fc54643e87496c1 Cherry pick #54532 to 23.7: Fix CI skip build and skip tests checks
…9aeb2138a5fa86fc54643e87496c1 Cherry pick #54532 to 23.8: Fix CI skip build and skip tests checks
…9aeb2138a5fa86fc54643e87496c1 Cherry pick #54532 to 23.9: Fix CI skip build and skip tests checks
Backport #54532 to 23.9: Fix CI skip build and skip tests checks
Backport #54532 to 23.3: Fix CI skip build and skip tests checks
Backport #54532 to 23.7: Fix CI skip build and skip tests checks
Backport #54532 to 23.8: Fix CI skip build and skip tests checks
Changelog category (leave one):
Updated can_skip_builds_and_use_version_from_master, can_skip_integration_tests, can_skip_functional_tests checks in ci resolves #54243