Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI skip build and skip tests checks #54532

Merged
merged 18 commits into from Sep 29, 2023
Merged

Conversation

SmitaRKulkarni
Copy link
Member

@SmitaRKulkarni SmitaRKulkarni commented Sep 12, 2023

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Updated can_skip_builds_and_use_version_from_master, can_skip_integration_tests, can_skip_functional_tests checks in ci resolves #54243

…tion_tests, can_skip_functional_tests checks in ci
@SmitaRKulkarni SmitaRKulkarni marked this pull request as draft September 12, 2023 08:33
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Sep 12, 2023
@robot-ch-test-poll4
Copy link
Contributor

robot-ch-test-poll4 commented Sep 12, 2023

This is an automated comment for commit c3f3824 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure

tests/ci/pr_info.py Outdated Show resolved Hide resolved
tests/ci/pr_info.py Outdated Show resolved Hide resolved
tests/ci/pr_info.py Outdated Show resolved Hide resolved
tests/ci/pr_info.py Show resolved Hide resolved
for f in self.changed_files:
# TODO: this logic is broken, should be fixed before using
if not f.startswith("tests/integration") or not f.startswith(
if not f.startswith("tests/integration") and not f.startswith(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it should be something more complex here.. We should check if the queries have changed. And split stateless and stateful tests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, so if its not built again, then source is not changes . So we want to check if functional tests have been changed and if not we skip them.
and we don't want to check the tests/queries/bugs folder ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I couldn't quickly find what's in the bugs directory. According to git log it's the temporary jail-directory for broken tests. So we need to track only 0_stateless 1_stateful directories indeed

@Felixoid Felixoid mentioned this pull request Sep 12, 2023
42 tasks
@Felixoid
Copy link
Member

I'd suggest as well check some particular tests/ci/*.lib files. But it will be fixed in #54540

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-status-⏳ PR with some pending statuses label Sep 13, 2023
@robot-ch-test-poll2 robot-ch-test-poll2 added pr-status-❌ PR with some error/faliure statuses and removed pr-status-⏳ PR with some pending statuses labels Sep 13, 2023
@robot-ch-test-poll3 robot-ch-test-poll3 added pr-status-⏳ PR with some pending statuses and removed pr-status-❌ PR with some error/faliure statuses labels Sep 13, 2023
@robot-ch-test-poll robot-ch-test-poll added pr-status-❌ PR with some error/faliure statuses and removed pr-status-⏳ PR with some pending statuses labels Sep 13, 2023
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added pr-status-⏳ PR with some pending statuses and removed pr-status-❌ PR with some error/faliure statuses labels Sep 13, 2023
@robot-clickhouse robot-clickhouse added pr-status-❌ PR with some error/faliure statuses and removed pr-status-⏳ PR with some pending statuses labels Sep 13, 2023
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added pr-status-⏳ PR with some pending statuses and removed pr-status-❌ PR with some error/faliure statuses pr-status-⏳ PR with some pending statuses labels Sep 13, 2023
@SmitaRKulkarni SmitaRKulkarni marked this pull request as ready for review September 26, 2023 08:09
Copy link
Member

@Felixoid Felixoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THanks a lot, let's merge it and move on!

@Felixoid Felixoid added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Sep 29, 2023
@Felixoid
Copy link
Member

The code is not active, so 100% didn't affect the tests

@Felixoid Felixoid merged commit fe155c6 into master Sep 29, 2023
274 of 277 checks passed
@Felixoid Felixoid deleted the Fix_ci_skip_build_and_skip_tests branch September 29, 2023 12:01
robot-ch-test-poll1 added a commit that referenced this pull request Sep 29, 2023
…9aeb2138a5fa86fc54643e87496c1

Cherry pick #54532 to 23.3: Fix CI skip build and skip tests checks
robot-ch-test-poll1 added a commit that referenced this pull request Sep 29, 2023
…9aeb2138a5fa86fc54643e87496c1

Cherry pick #54532 to 23.7: Fix CI skip build and skip tests checks
robot-ch-test-poll1 added a commit that referenced this pull request Sep 29, 2023
…9aeb2138a5fa86fc54643e87496c1

Cherry pick #54532 to 23.8: Fix CI skip build and skip tests checks
robot-ch-test-poll1 added a commit that referenced this pull request Sep 29, 2023
…9aeb2138a5fa86fc54643e87496c1

Cherry pick #54532 to 23.9: Fix CI skip build and skip tests checks
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Sep 29, 2023
Felixoid added a commit that referenced this pull request Sep 29, 2023
Backport #54532 to 23.9: Fix CI skip build and skip tests checks
Felixoid added a commit that referenced this pull request Sep 29, 2023
Backport #54532 to 23.3: Fix CI skip build and skip tests checks
Felixoid added a commit that referenced this pull request Sep 29, 2023
Backport #54532 to 23.7: Fix CI skip build and skip tests checks
Felixoid added a commit that referenced this pull request Sep 29, 2023
Backport #54532 to 23.8: Fix CI skip build and skip tests checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-not-for-changelog This PR should not be mentioned in the changelog pr-status-✅ PR with only success statuses
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the metods in PRInfo can_skip_{some_workflow_step}
10 participants