Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not build and upload apk packages, nobody uses them #54675

Merged
merged 1 commit into from Sep 15, 2023

Conversation

Felixoid
Copy link
Member

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

We build and upload them for every push, which isn't worth it.

@robot-ch-test-poll2 robot-ch-test-poll2 added pr-build Pull request with build/testing/packaging improvement pr-status-⏳ PR with some pending statuses labels Sep 15, 2023
@robot-ch-test-poll2
Copy link
Contributor

robot-ch-test-poll2 commented Sep 15, 2023

This is an automated comment for commit c6e531a with description of existing statuses. It's updated for the latest CI running

⏳ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending

@Felixoid Felixoid merged commit 850a6c9 into master Sep 15, 2023
84 of 179 checks passed
@Felixoid Felixoid deleted the disable-apk-packages branch September 15, 2023 16:20
@Felixoid Felixoid added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Sep 15, 2023
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Sep 15, 2023
Felixoid added a commit that referenced this pull request Sep 15, 2023
Backport #54675 to 23.3: Do not build and upload apk packages, nobody uses them
Felixoid added a commit that referenced this pull request Sep 15, 2023
Backport #54675 to 23.6: Do not build and upload apk packages, nobody uses them
Felixoid added a commit that referenced this pull request Sep 15, 2023
Backport #54675 to 23.8: Do not build and upload apk packages, nobody uses them
Felixoid added a commit that referenced this pull request Sep 15, 2023
Backport #54675 to 23.7: Do not build and upload apk packages, nobody uses them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-build Pull request with build/testing/packaging improvement pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-status-⏳ PR with some pending statuses
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants