Fix virtual columns having incorrect values after ORDER BY

[al13n321]

Changelog category (leave one):

• Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixed virtual columns (e.g. _file) showing incorrect values with ORDER BY.

Repro:

insert into function file('t1.csv') select 1 as x;
insert into function file('t2.csv') select 2 as x;
select _file, * from file('t{1,2}.csv') order by _file settings max_threads=1;

┌─_file──┬─c1─┐
│ t1.csv │  1 │
│ t1.csv │  2 │
└────────┴────┘

The storage was outputting ColumnConst, then sorting transform was concatenating them using insertRangeFrom(), which doesn't check if the values are equal.

I don't know what's the intended way for this to work.
(1) Maybe storages are supposed to produce full columns only?
(2) Maybe ColumnConst::insertRangeFrom() should throw an exception if values are different (this won't fix this problem but would make it more noticeable).
(3) Maybe there should be something like static IColumn::concat(ColumnPtr & a, IColumn & b), which would automatically convert a to full column if values are different?

This PR does the simplest thing (1) and just always materializes virtual columns. Lmk if that's not good enough.

[robot-ch-test-poll]

This is an automated comment for commit 4958b16 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	✅ success
Bugfix validate check	Checks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch	✅ success
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	✅ success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker image for servers	The check to build and optionally push the mentioned image to docker hub	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	✅ success
Mergeable Check	Checks if all other necessary checks are successful	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
Push to Dockerhub	The check for building and pushing the CI related docker images to docker hub	✅ success
SQLTest	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	✅ success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	✅ success
Style Check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

Check name	Description	Status
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	❌ failure

[nikitamikhaylov]

If we would agree to proceed with option (1), then the comment is needed which describes this behaviour + we need to check other places where we inject virtual columns.

[Avogar]

Originally virtual columns were materialized, but I changed it recently to ColumnConst to optimize queries like

select count(), _file from file(...) group by _file

With ColumnConst there are 2 optimizations:

1. Not materializing ColumnConst saves some time.
2. Recently I made an optimization for group by with constant keys.

We can compare master and build from this PR.
master:

avogar-dev :) select count(), _file, _path from file('data5.parquet') group by _file, _path

SELECT
    count(),
    _file,
    _path
FROM file('data5.parquet')
GROUP BY
    _file,
    _path

Query id: 9bf61dcc-5a3d-4ff8-b324-a72b74dd1a70

┌───count()─┬─_file─────────┬─_path───────────────────────────────┐
│ 100000000 │ data5.parquet │ /home/avogar/tmp/data/data5.parquet │
└───────────┴───────────────┴─────────────────────────────────────┘

1 row in set. Elapsed: 0.030 sec.

This PR:

avogar-dev :) select count(), _file, _path from file('data5.parquet') group by _file, _path

SELECT
    count(),
    _file,
    _path
FROM file('data5.parquet')
GROUP BY
    _file,
    _path

Query id: 1bca7eb3-5c53-4eae-a59f-ea4997f79a24

┌───count()─┬─_file─────────┬─_path───────────────────────────────┐
│ 100000000 │ data5.parquet │ /home/avogar/tmp/data/data5.parquet │
└───────────┴───────────────┴─────────────────────────────────────┘

1 row in set. Elapsed: 0.474 sec. Processed 86.80 million rows, 0.00 B (183.27 million rows/s., 0.00 B/s.)
Peak memory usage: 113.94 MiB.

Also we have such queries in performance tests, but for some reason not all queries from count_from_formats perf test were executed and we don't see slower queries in performance test

So, I would prefer trying to make ColumnConst work with ORDER BY if it's possible

[Avogar]

Maybe we can merge this PR as fast fix (and backport it to 23.8) and then think of better solution

[al13n321]

Trying to make ColumnConst work in #54866

[SaltTan]

@Avogar v23.8-must-backport ?