New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent attaching parts from tables with different projections or indices #55062
Merged
pufit
merged 3 commits into
master
from
prevent-attaching-part-from-table-with-different-definition
Sep 27, 2023
Merged
Prevent attaching parts from tables with different projections or indices #55062
pufit
merged 3 commits into
master
from
prevent-attaching-part-from-table-with-different-definition
Sep 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll2
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Sep 27, 2023
This is an automated comment for commit 97e698b with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
pufit
approved these changes
Sep 27, 2023
test_delayed_replica_failover/test.py::test - #54502 |
pufit
deleted the
prevent-attaching-part-from-table-with-different-definition
branch
September 27, 2023 19:02
I think it is not exactly the same, but it might be connected. |
antaljanosbenjamin
added
pr-backport
Changes, backported to release branch. Do not use manually - automated use only!
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-must-backport-cloud
and removed
pr-backport
Changes, backported to release branch. Do not use manually - automated use only!
labels
Oct 10, 2023
robot-ch-test-poll3
added a commit
that referenced
this pull request
Oct 10, 2023
…d626315d6b67f35ed7ea0f6c476ce Cherry pick #55062 to 23.7: Prevent attaching parts from tables with different projections or indices
robot-clickhouse
added a commit
that referenced
this pull request
Oct 10, 2023
…ferent projections or indices
robot-ch-test-poll3
added a commit
that referenced
this pull request
Oct 10, 2023
…d626315d6b67f35ed7ea0f6c476ce Cherry pick #55062 to 23.8: Prevent attaching parts from tables with different projections or indices
robot-clickhouse
added a commit
that referenced
this pull request
Oct 10, 2023
…ferent projections or indices
alexey-milovidov
added a commit
that referenced
this pull request
Oct 12, 2023
Backport #55062 to 23.8: Prevent attaching parts from tables with different projections or indices
alexey-milovidov
added a commit
that referenced
this pull request
Oct 12, 2023
Backport #55062 to 23.7: Prevent attaching parts from tables with different projections or indices
robot-ch-test-poll2
added a commit
that referenced
this pull request
Oct 12, 2023
…d626315d6b67f35ed7ea0f6c476ce Cherry pick #55062 to 23.3: Prevent attaching parts from tables with different projections or indices
robot-clickhouse
added a commit
that referenced
this pull request
Oct 12, 2023
…ferent projections or indices
robot-ch-test-poll2
added
the
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
label
Oct 12, 2023
robot-clickhouse-ci-1
added a commit
that referenced
this pull request
Oct 12, 2023
Backport #55062 to 23.3: Prevent attaching parts from tables with different projections or indices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-backports-created-cloud
pr-bugfix
Pull request with bugfix, not backported by default
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-must-backport-cloud
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Prevent attaching partitions from tables that doesn't have the same indices or projections defined.
Documentation entry for user-facing changes
Fixes #54896.
Not the best solution in terms flexibility, but at least prevents ClickHouse from crashing. In the future we might allow attaching parts if we can attach the parts easily (e.g.: the source tables has extra indices or tables we might be able to ignore those extra projections and indices.
See slightly related issues #13826 and #39507.