Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Dockerfiles for keeper and server images #55717

Merged
merged 4 commits into from Oct 18, 2023
Merged

Conversation

Felixoid
Copy link
Member

@Felixoid Felixoid commented Oct 17, 2023

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Check sha512 for tgz; use a proper repository for keeper; write only filenames to TGZ.sha512 files for tarball packages. Prerequisite for #31473

@robot-ch-test-poll robot-ch-test-poll added the pr-build Pull request with build/testing/packaging improvement label Oct 17, 2023
@robot-ch-test-poll
Copy link
Contributor

robot-ch-test-poll commented Oct 17, 2023

This is an automated comment for commit af31224 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure

@antaljanosbenjamin antaljanosbenjamin self-assigned this Oct 17, 2023
@Felixoid Felixoid force-pushed the tune-dockerfiles branch 2 times, most recently from bc66357 to 84d880b Compare October 17, 2023 13:01
@Felixoid Felixoid merged commit 8935c6c into master Oct 18, 2023
266 of 274 checks passed
@Felixoid Felixoid deleted the tune-dockerfiles branch October 18, 2023 17:04
@Felixoid
Copy link
Member Author

I'll backport it to LTS versions to have them in sync

robot-ch-test-poll2 added a commit that referenced this pull request Oct 19, 2023
…283351409a20554948a7f86a06f1a

Cherry pick #55717 to 23.3: Improve Dockerfiles for keeper and server images
robot-ch-test-poll2 added a commit that referenced this pull request Oct 19, 2023
…283351409a20554948a7f86a06f1a

Cherry pick #55717 to 23.8: Improve Dockerfiles for keeper and server images
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Oct 19, 2023
robot-ch-test-poll added a commit that referenced this pull request Oct 19, 2023
Backport #55717 to 23.3: Improve Dockerfiles for keeper and server images
Felixoid added a commit that referenced this pull request Oct 20, 2023
Backport #55717 to 23.8: Improve Dockerfiles for keeper and server images
@Felixoid Felixoid added v23.9-must-backport and removed pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore labels Nov 27, 2023
robot-ch-test-poll4 added a commit that referenced this pull request Nov 27, 2023
…283351409a20554948a7f86a06f1a

Cherry pick #55717 to 23.9: Improve Dockerfiles for keeper and server images
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Nov 27, 2023
ch-devops pushed a commit to ClibMouse/ClickHouse that referenced this pull request Nov 28, 2023
Backport ClickHouse#55717 to 23.9: Improve Dockerfiles for keeper and server images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-build Pull request with build/testing/packaging improvement v23.3-must-backport v23.8-must-backport v23.9-must-backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants