Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use diff object again, since JSON API limits the files #55750

Merged
merged 1 commit into from Oct 17, 2023
Merged

Use diff object again, since JSON API limits the files #55750

merged 1 commit into from Oct 17, 2023

Conversation

Felixoid
Copy link
Member

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

@Felixoid Felixoid requested a review from maxknv October 17, 2023 15:51
@Felixoid Felixoid added the do not test disable testing on pull request label Oct 17, 2023
@robot-ch-test-poll robot-ch-test-poll added the pr-not-for-changelog This PR should not be mentioned in the changelog label Oct 17, 2023
@robot-ch-test-poll
Copy link
Contributor

This is an automated comment for commit b382705 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success

maxknv
maxknv approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@maxknv maxknv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robot-ch-test-poll3 robot-ch-test-poll3 merged commit e85bf21 into master Oct 17, 2023
6 of 153 checks passed
@robot-ch-test-poll3 robot-ch-test-poll3 deleted the use-diff-object-in-pr_info branch October 17, 2023 16:02
@Felixoid
Copy link
Member Author

It's already in each backport, so no need to bother

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxknv maxknv maxknv approved these changes

Assignees
No one assigned
Labels
do not test disable testing on pull request pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Felixoid @robot-ch-test-poll @maxknv @robot-ch-test-poll3