Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin rust version to fix GLIBC compatibility check #55788

Merged
merged 1 commit into from Oct 18, 2023

Conversation

Felixoid
Copy link
Member

Attempt to fix compatibility check

@Felixoid Felixoid added the pr-backport Changes, backported to release branch. Do not use manually - automated use only! label Oct 18, 2023
@robot-ch-test-poll2
Copy link
Contributor

robot-ch-test-poll2 commented Oct 18, 2023

This is an automated comment for commit 492e0e5 with description of existing statuses. It's updated for the latest CI running

⏳ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending

@Felixoid
Copy link
Member Author

@azat here the issue with GLIBC from #54424 #55597 #55671 #55734 is solved. The difference between these PRs and the working one is in the rust version in the image

root@727fdf0ab974:/workdir# rustc --version
rustc 1.73.0 (cc66ad468 2023-10-03)
root@09e38a051b87:/workdir# rustc --version
rustc 1.71.0 (8ede3aae2 2023-07-12)

It looks like 1.73 version is pretty dangerous for us

@Felixoid
Copy link
Member Author

Merging it to have 23.3 backports fixed

@Felixoid Felixoid merged commit 3225654 into 23.3 Oct 18, 2023
27 of 34 checks passed
@Felixoid Felixoid deleted the backport/23.3/pin-rust-version branch October 18, 2023 16:05
@azat
Copy link
Collaborator

azat commented Oct 18, 2023

It looks like 1.73 version is pretty dangerous for us

Yes, nightly eventually will break glibc compatibility.
I remember that it was the issue before, but I just removed some crates/features and this had been fixed.

The problem here is that there is a huge dependency list of crates, and this is the problem not only to the used symbols from glibc but for server safety as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backport Changes, backported to release branch. Do not use manually - automated use only!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants