Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve enrich image #55793

Merged
merged 2 commits into from Oct 19, 2023
Merged

Improve enrich image #55793

merged 2 commits into from Oct 19, 2023

Conversation

Felixoid
Copy link
Member

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Tiny improvement to have tags with proper pr-sha tags.

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Oct 18, 2023
@robot-clickhouse
Copy link
Member

robot-clickhouse commented Oct 18, 2023 •
edited by robot-ch-test-poll4

This is an automated comment for commit b9253d2 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

@Felixoid
Copy link
Member Author

https://github.com/ClickHouse/ClickHouse/actions/runs/6565040826/job/17832955748?pr=55793#step:6:101

it works

@Felixoid Felixoid added pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud do not test disable testing on pull request labels Oct 18, 2023
@Felixoid Felixoid requested a review from maxknv October 18, 2023 18:44
maxknv
maxknv approved these changes Oct 19, 2023
View reviewed changes
tests/ci/docker_manifests_merge.py Outdated Show resolved Hide resolved
@antaljanosbenjamin
Copy link
Member

Thanks @Felixoid for the very nice fix!

@Felixoid Felixoid force-pushed the improve-enrich-image branch 2 times, most recently from b9253d2 to cbb530b Compare October 19, 2023 09:34
@Felixoid Felixoid merged commit 170925c into master Oct 19, 2023
151 of 152 checks passed
@Felixoid Felixoid deleted the improve-enrich-image branch October 19, 2023 10:31
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Oct 19, 2023
Merged
robot-ch-test-poll added a commit that referenced this pull request Oct 19, 2023
@robot-ch-test-poll
Merge pull request #55816 from ClickHouse/cherrypick/23.3/170925cb3cb…
f2c8ae2 
…0058dabdb8f72774c52f40be049da

Cherry pick #55793 to 23.3: Improve enrich image
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Oct 19, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Oct 19, 2023
@robot-clickhouse
Backport #55793 to 23.3: Improve enrich image
2785295
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Oct 19, 2023
Merged
robot-ch-test-poll added a commit that referenced this pull request Oct 19, 2023
@robot-ch-test-poll
Merge pull request #55818 from ClickHouse/cherrypick/23.7/170925cb3cb…
4d8d244 
…0058dabdb8f72774c52f40be049da

Cherry pick #55793 to 23.7: Improve enrich image
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Oct 19, 2023
Closed
robot-clickhouse added a commit that referenced this pull request Oct 19, 2023
@robot-clickhouse
Backport #55793 to 23.7: Improve enrich image
89c667b
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Oct 19, 2023
Merged
robot-ch-test-poll added a commit that referenced this pull request Oct 19, 2023
@robot-ch-test-poll
Merge pull request #55820 from ClickHouse/cherrypick/23.8/170925cb3cb…
67b1b3e 
…0058dabdb8f72774c52f40be049da

Cherry pick #55793 to 23.8: Improve enrich image
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Oct 19, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Oct 19, 2023
@robot-clickhouse
Backport #55793 to 23.8: Improve enrich image
c816e79
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Oct 19, 2023
Merged
robot-ch-test-poll added a commit that referenced this pull request Oct 19, 2023
@robot-ch-test-poll
Merge pull request #55822 from ClickHouse/cherrypick/23.9/170925cb3cb…
93cb13d 
…0058dabdb8f72774c52f40be049da

Cherry pick #55793 to 23.9: Improve enrich image
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Oct 19, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Oct 19, 2023
@robot-clickhouse
Backport #55793 to 23.9: Improve enrich image
f6a8045
@robot-ch-test-poll robot-ch-test-poll added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Oct 19, 2023
robot-ch-test-poll4 added a commit that referenced this pull request Oct 19, 2023
@robot-ch-test-poll4
Merge pull request #55817 from ClickHouse/backport/23.3/55793
e41d151 
Backport #55793 to 23.3: Improve enrich image
Felixoid added a commit that referenced this pull request Nov 6, 2023
@Felixoid
Merge pull request #55821 from ClickHouse/backport/23.8/55793
9edb42a 
Backport #55793 to 23.8: Improve enrich image
alexey-milovidov added a commit that referenced this pull request Nov 16, 2023
@alexey-milovidov
Merge pull request #55823 from ClickHouse/backport/23.9/55793
a10814f 
Backport #55793 to 23.9: Improve enrich image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxknv maxknv maxknv approved these changes

@antaljanosbenjamin antaljanosbenjamin Awaiting requested review from antaljanosbenjamin

Assignees

@maxknv maxknv

Labels
do not test disable testing on pull request pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Felixoid @robot-clickhouse @antaljanosbenjamin @maxknv @robot-ch-test-poll @robot-ch-test-poll2