-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite DELETE docs #55856
Rewrite DELETE docs #55856
Conversation
This is an automated comment for commit 7738f3a with description of existing statuses. It's updated for the latest CI running ⏳ Click here to open a full report in a separate page Successful checks
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice set of changes, thank you
I was wondering - should we perhaps be recommending wide parts in all use cases where many deletions are expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also compare it to the ALTER TABLE ... DELETE
in ways that ALTER DELETE
will actually delete the data, but it will recreate all the affected parts, which may take a lot of resources at the moment of deletion. At the same time, the DELETE
query will not load ClickHouse as much because we only mark the rows as deleted, but it may take a lot of time for the data to be actually deleted.
@evillique Thank you for reviewing. I believe I've addressed all of your feedback above in the most recent commit. Please let me know if there are any more changes I should make. |
May be it has sense to put _row_exists into a separate file always, even if a part is compact. Compact parts are introduced to solve the overhead of small inserts, but delete happens when inserts already done (no overhead) and this column does not exists in the data.bin (no need to update data in the data.bin). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect, thank you!
thank you @evillique @justindeguzman ! 🙏 |
Changelog category (leave one):