Use CH Buffer for HTTP out stream, add metrics for interfaces #56064

yakov-olkhovskiy · 2023-10-27T02:43:38Z

Changelog category (leave one):

Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Replace HTTP outgoing buffering based on std ostream with CH Buffer.
Add bytes counting metrics for interfaces.

robot-ch-test-poll1 · 2023-10-27T02:44:54Z

This is an automated comment for commit db97764 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	✅ success
ClickBench	Runs [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table	✅ success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker image for servers	The check to build and optionally push the mentioned image to docker hub	✅ success
Docs check	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	✅ success
Mergeable Check	Checks if all other necessary checks are successful	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
SQLTest	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	✅ success
Style Check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

Check name	Description	Status
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	⏳ pending
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	❌ failure

… Content-Encoding if no data

src/Common/CurrentMetrics.cpp

src/IO/WriteBufferFromPocoSocket.cpp

src/IO/ZstdDeflatingWriteBuffer.cpp

CheSema · 2023-12-18T13:56:54Z

Some perf tests are failed. Interesting what is the reason.

yakov-olkhovskiy · 2023-12-18T14:11:14Z

I guess because we had some problems with CI yesterday

…e-metrics

…e-server-iface-metrics

alexey-milovidov · 2023-12-30T17:40:11Z

src/IO/CompressionMethod.cpp

-    throw Exception(ErrorCodes::NOT_IMPLEMENTED, "Unsupported compression method");
+
+std::unique_ptr<WriteBuffer> wrapWriteBufferWithCompressionMethod(
+    WriteBuffer * nested,


This looks dangerous.

this is to support not owning version of WriteBufferDecorator where nested is decorated but not owned by decorator

alexey-milovidov · 2023-12-30T17:40:29Z

src/IO/LZMADeflatingWriteBuffer.h

    LZMADeflatingWriteBuffer(
-        std::unique_ptr<WriteBuffer> out_,
+        WriteBufferT && out_,


Is it necessary?

LZMADeflatingWriteBuffer is inherited from WriteBufferWithOwnMemoryDecorator which is a specialization of WriteBufferDecorator and should now accommodate both owning and non-owning construction

alexey-milovidov · 2023-12-30T17:41:18Z

tests/queries/0_stateless/02373_progress_contain_result.sh

@@ -5,5 +5,5 @@ CURDIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
 . "$CURDIR"/../shell_config.sh

 echo 'SELECT 1 FROM numbers(100)' |
-  ${CLICKHOUSE_CURL_COMMAND} -v "${CLICKHOUSE_URL}&wait_end_of_query=1&send_progress_in_http_headers=0" --data-binary @- 2>&1 |
+  ${CLICKHOUSE_CURL_COMMAND} -vs "${CLICKHOUSE_URL}&wait_end_of_query=1&send_progress_in_http_headers=0" --data-binary @- 2>&1 |


When you pass -s (--silent) option to curl, you should always also specify -S (not ignore errors).

alexey-milovidov · 2023-12-30T17:41:26Z

tests/queries/0_stateless/02293_http_header_full_summary_without_progress.sh

@@ -7,7 +7,7 @@ CURDIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)


 CURL_OUTPUT=$(echo 'SELECT 1 + sleepEachRow(0.00002) FROM numbers(100000)' | \
-  ${CLICKHOUSE_CURL_COMMAND} -v "${CLICKHOUSE_URL}&wait_end_of_query=1&send_progress_in_http_headers=0&max_execution_time=1" --data-binary @- 2>&1)
+  ${CLICKHOUSE_CURL_COMMAND} -vs "${CLICKHOUSE_URL}&wait_end_of_query=1&send_progress_in_http_headers=0&max_execution_time=1" --data-binary @- 2>&1)


alexey-milovidov · 2023-12-30T17:42:21Z

src/Server/TCPHandler.h

@@ -147,8 +147,8 @@ class TCPHandler : public Poco::Net::TCPServerConnection
      *  because it allows to check the IP ranges of the trusted proxy.
      * Proxy-forwarded (original client) IP address is used for quota accounting if quota is keyed by forwarded IP.
      */
-    TCPHandler(IServer & server_, TCPServer & tcp_server_, const Poco::Net::StreamSocket & socket_, bool parse_proxy_protocol_, std::string server_display_name_);
-    TCPHandler(IServer & server_, TCPServer & tcp_server_, const Poco::Net::StreamSocket & socket_, TCPProtocolStackData & stack_data, std::string server_display_name_);
+    TCPHandler(IServer & server_, TCPServer & tcp_server_, const Poco::Net::StreamSocket & socket_, bool parse_proxy_protocol_, std::string server_display_name_, const ProfileEvents::Event & read_event_ = ProfileEvents::end(), const ProfileEvents::Event & write_event_ = ProfileEvents::end());


Event can be passed by value, and also we can use std::optional.

const & accommodates by value and I made defaults rather than optional to make changes less intrusive...

alexey-milovidov · 2023-12-30T17:43:10Z

src/Server/PostgreSQLHandler.h

@@ -33,7 +33,9 @@ class PostgreSQLHandler : public Poco::Net::TCPServerConnection
        TCPServer & tcp_server_,
        bool ssl_enabled_,
        Int32 connection_id_,
-        std::vector<std::shared_ptr<PostgreSQLProtocol::PGAuthentication::AuthenticationMethod>> & auth_methods_);
+        std::vector<std::shared_ptr<PostgreSQLProtocol::PGAuthentication::AuthenticationMethod>> & auth_methods_,
+        const ProfileEvents::Event & read_event_ = ProfileEvents::end(),


alexey-milovidov · 2023-12-30T17:43:55Z

src/Server/NotFoundHandler.cpp

-                         << "    clickhouse-client --query='SELECT 1' > result\n"
-                         << "    clickhouse-client < query > result\n";
+        auto out = response.send();
+        out->write("There is no handle ");


There is also a nice thing - IO/Operators.h
(optional)

alexey-milovidov · 2023-12-30T18:01:51Z

Wow, that's a huge improvement! This is really amazing!

23.11:

$ curl http://localhost:8123/ -d 'SELECT number FROM system.numbers_mt LIMIT 1000000000 FORMAT JSON' > /dev/null
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 31.5G    0 31.5G  100    65  1138M      2  0:00:32  0:00:28  0:00:04 1101M

This PR:

$ curl http://localhost:8123/ -d 'SELECT number FROM system.numbers_mt LIMIT 1000000000 FORMAT JSON' > /dev/null
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 31.5G    0 31.5G  100    65  3204M      6  0:00:10  0:00:10 --:--:-- 3185M

* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20240103) * [CH] Fix build due to ClickHouse/ClickHouse#56064 --------- Co-authored-by: kyligence-git <gluten@kyligence.io>

use CH Buffer for HTTP out stream, add metrics for interfaces

0cf8513

robot-ch-test-poll1 added the pr-improvement Pull request with some product improvements label Oct 27, 2023

yakov-olkhovskiy added 20 commits October 27, 2023 04:58

fix style

53402da

fix

c12b3c5

fix finalize

ec8d7a9

more fixes

aa855aa

fix http compression setting

b64b009

fix

5ef2449

fix

6ed150b

fix

7887e1e

compressors to not produce output for no data, HTTP buffer not to add…

d72069d

… Content-Encoding if no data

fix

9c34ac5

fix

e1d0994

fix

9f4be7e

fix X-ClickHouse-Exception-Code

43c2c83

fix send HTTP header

ad3b46b

early session ID release

ba72cf4

prevent curl from printing stats - messes up output

f39e803

fix clang tidy

4f11132

fix clang tidy

d9fe33a

fix test

c11450f

release session id earlier

c66c7c0

CheSema self-assigned this Nov 16, 2023

CheSema reviewed Nov 16, 2023

View reviewed changes

src/Common/CurrentMetrics.cpp Outdated Show resolved Hide resolved

CheSema reviewed Nov 16, 2023

View reviewed changes

src/IO/WriteBufferFromPocoSocket.cpp Outdated Show resolved Hide resolved

CheSema reviewed Nov 16, 2023

View reviewed changes

src/IO/ZstdDeflatingWriteBuffer.cpp Show resolved Hide resolved

alexey-milovidov mentioned this pull request Nov 19, 2023

Bypass Poco::BasicBufferedStreamBuf in ReadBufferFromIStream #56961

Merged

yakov-olkhovskiy and others added 2 commits November 27, 2023 15:44

Merge branch 'master' into feature-server-iface-metrics

b92030b

fix after merge

4d40ed8

optimize event update

42a770f

yakov-olkhovskiy added the can be tested Allows running workflows for external contributors label Dec 16, 2023

yakov-olkhovskiy and others added 9 commits December 18, 2023 14:14

Merge remote-tracking branch 'origin/master' into feature-server-ifac…

f99b361

…e-metrics

Merge branch 'master' into feature-server-iface-metrics

5dc8854

fix after merge

d8bfb01

Merge branch 'master' into feature-server-iface-metrics

aa462fa

Merge branch 'master' into feature-server-iface-metrics

aad63c8

Merge with master

01c7562

Remove commented code

a1bd763

Merge branch 'master' of github.com:ClickHouse/ClickHouse into featur…

68cc3ea

…e-server-iface-metrics

Remove commented code

2f3e17c

alexey-milovidov reviewed Dec 30, 2023

View reviewed changes

fix tests, some refactoring

db97764

CheSema approved these changes Jan 2, 2024

View reviewed changes

yakov-olkhovskiy merged commit 5633fb8 into master Jan 2, 2024
241 of 255 checks passed

yakov-olkhovskiy deleted the feature-server-iface-metrics branch January 2, 2024 15:17

lwz9103 added a commit to Kyligence/gluten that referenced this pull request Jan 3, 2024

[CH] Fix build due to ClickHouse/ClickHouse#56064

ffe2821

Algunenano mentioned this pull request Jan 3, 2024

Revert "Use CH Buffer for HTTP out stream, add metrics for interfaces" #58450

Merged

tavplubix mentioned this pull request Jan 3, 2024

Fix 02944_dynamically_change_filesystem_cache_size #58445

Merged

azat mentioned this pull request Jan 19, 2024

Fix timeout for prometheus exporter for HTTP/1.1 (due to keep-alive) #58981

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use CH Buffer for HTTP out stream, add metrics for interfaces #56064

Use CH Buffer for HTTP out stream, add metrics for interfaces #56064

yakov-olkhovskiy commented Oct 27, 2023

robot-ch-test-poll1 commented Oct 27, 2023 •

edited by robot-clickhouse-ci-2

CheSema commented Dec 18, 2023

yakov-olkhovskiy commented Dec 18, 2023

alexey-milovidov Dec 30, 2023

yakov-olkhovskiy Dec 30, 2023

alexey-milovidov Dec 30, 2023

yakov-olkhovskiy Dec 30, 2023

alexey-milovidov Dec 30, 2023

alexey-milovidov Dec 30, 2023

alexey-milovidov Dec 30, 2023

yakov-olkhovskiy Dec 30, 2023

alexey-milovidov Dec 30, 2023

alexey-milovidov Dec 30, 2023

alexey-milovidov commented Dec 30, 2023

Use CH Buffer for HTTP out stream, add metrics for interfaces #56064

Use CH Buffer for HTTP out stream, add metrics for interfaces #56064

Conversation

yakov-olkhovskiy commented Oct 27, 2023

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

robot-ch-test-poll1 commented Oct 27, 2023 • edited by robot-clickhouse-ci-2

CheSema commented Dec 18, 2023

yakov-olkhovskiy commented Dec 18, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexey-milovidov commented Dec 30, 2023

robot-ch-test-poll1 commented Oct 27, 2023 •

edited by robot-clickhouse-ci-2