Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve CI with digest for docker, build and test jobs #56317

Merged
merged 6 commits into from
Dec 15, 2023
Merged

Conversation

maxknv
Copy link
Member

@maxknv maxknv commented Nov 3, 2023

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

CI refactoring that implements digest approach to serve several goals:

  1. digest docker images and use digest as a tag to ease the search of required images
  2. digest build and tests to support job skipping in case it was successfully done before
  3. small improvement for style check to do it before docker build job if possible (image not changed)

resolves #56015

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 3, 2023
@robot-clickhouse-ci-2
Copy link
Contributor

robot-clickhouse-ci-2 commented Nov 3, 2023

This is an automated comment for commit 42d5a4e with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
Docs checkThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure

@maxknv maxknv force-pushed the ci_with_digest branch 28 times, most recently from c423375 to 9697d13 Compare November 5, 2023 10:23
@maxknv maxknv force-pushed the ci_with_digest branch 4 times, most recently from 2a0229b to ed6b52a Compare December 14, 2023 00:53
@maxknv maxknv force-pushed the ci_with_digest branch 14 times, most recently from e92991c to b57e122 Compare December 15, 2023 08:38
@maxknv maxknv merged commit 7844fcc into master Dec 15, 2023
101 of 106 checks passed
@maxknv maxknv deleted the ci_with_digest branch December 15, 2023 14:21
maxknv added a commit that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC] Boost up CI with source files Digest
3 participants