-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump gRPC to v1.55.4 and protobuf to v22.5 #56664
Conversation
This is an automated comment for commit e8eb425 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
Is my understanding correct that those versions do not yet require updating |
Editions are introduced only with protobuf v25. |
This comment was marked as resolved.
This comment was marked as resolved.
Noted. Is there still a need for updating protobuf and gRPC to the latest and update the |
@mkmkme Eventually yes, but in a future PR. gRPC and protobuf are quite hairy and can only be upgraded in "lockstep" (I believe this was also your experience). I have been trying to upgrade both but it is a slow process. Even with this PR, both are behind their current upstream versions. "Editions" are introduced with the latest and greatest protobuf that (I speculate) can be introduced in two weeks at the earliest with the current pace. I can continue the upgrade process, and in case I have questions I may come back to you. |
@Algunenano I'd appreciate if you could take a look + possibly approve, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There is a cmake warning for grpc but I don't know if it was introduced in this PR or one of the prior ones:
-- Adding contrib module grpc (configuring with grpc-cmake)
CMake Warning (dev) at contrib/grpc/CMakeLists.txt:50 (option):
Policy CMP0077 is not set: option() honors normal variables. Run "cmake
--help-policy CMP0077" for policy details. Use the cmake_policy command to
set the policy and suppress this warning.
For compatibility with older versions of CMake, option is clearing the
normal variable 'gRPC_BUILD_CSHARP_EXT'.
This warning is for project developers. Use -Wno-dev to suppress it.
Thanks. The warning technically existed already before this PR but more likely it was introduced with one of my many earlier gRPC updates. I'll check if I can get rid of it. |
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20231117) * fix build due to ClickHouse/ClickHouse#56664 --------- Co-authored-by: kyligence-git <gluten@kyligence.io> Co-authored-by: Chang Chen <baibaichen@gmail.com>
See #56543
(this PR will accumulate multiple version bumps, cf. #56059 (review) EDIT: No, it won't as v1.55.4 required some major changes)
Bumped gRPC to v1.55.4, this was only possible by also bumping protobuf to v22.5
Changelog category (leave one):