Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gRPC to v1.55.4 and protobuf to v22.5 #56664

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

rschu1ze
Copy link
Member

@rschu1ze rschu1ze commented Nov 13, 2023

See #56543

(this PR will accumulate multiple version bumps, cf. #56059 (review) EDIT: No, it won't as v1.55.4 required some major changes)

Bumped gRPC to v1.55.4, this was only possible by also bumping protobuf to v22.5

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR. labels Nov 13, 2023
@robot-clickhouse-ci-1
Copy link
Contributor

robot-clickhouse-ci-1 commented Nov 13, 2023

This is an automated comment for commit e8eb425 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure

@mkmkme
Copy link
Contributor

mkmkme commented Nov 13, 2023

Is my understanding correct that those versions do not yet require updating proto file to use editions?

@rschu1ze
Copy link
Member Author

Editions are introduced only with protobuf v25.

@rschu1ze

This comment was marked as resolved.

@mkmkme
Copy link
Contributor

mkmkme commented Nov 14, 2023

Editions are introduced only with protobuf v25.

Noted. Is there still a need for updating protobuf and gRPC to the latest and update the proto file (as discussed in Slack)?

@rschu1ze
Copy link
Member Author

Noted. Is there still a need for updating protobuf and gRPC to the latest and update the proto file (as discussed in Slack)?

@mkmkme Eventually yes, but in a future PR. gRPC and protobuf are quite hairy and can only be upgraded in "lockstep" (I believe this was also your experience). I have been trying to upgrade both but it is a slow process. Even with this PR, both are behind their current upstream versions. "Editions" are introduced with the latest and greatest protobuf that (I speculate) can be introduced in two weeks at the earliest with the current pace. I can continue the upgrade process, and in case I have questions I may come back to you.

@rschu1ze rschu1ze marked this pull request as ready for review November 14, 2023 19:14
@rschu1ze
Copy link
Member Author

@Algunenano I'd appreciate if you could take a look + possibly approve, thanks.

@Algunenano Algunenano self-assigned this Nov 14, 2023
Copy link
Member

@Algunenano Algunenano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

There is a cmake warning for grpc but I don't know if it was introduced in this PR or one of the prior ones:

-- Adding contrib module grpc (configuring with grpc-cmake)
CMake Warning (dev) at contrib/grpc/CMakeLists.txt:50 (option):
  Policy CMP0077 is not set: option() honors normal variables.  Run "cmake
  --help-policy CMP0077" for policy details.  Use the cmake_policy command to
  set the policy and suppress this warning.

  For compatibility with older versions of CMake, option is clearing the
  normal variable 'gRPC_BUILD_CSHARP_EXT'.
This warning is for project developers.  Use -Wno-dev to suppress it.

@rschu1ze
Copy link
Member Author

Thanks. The warning technically existed already before this PR but more likely it was introduced with one of my many earlier gRPC updates. I'll check if I can get rid of it.

@rschu1ze rschu1ze merged commit 8fe093c into ClickHouse:master Nov 16, 2023
332 of 338 checks passed
baibaichen added a commit to Kyligence/gluten that referenced this pull request Nov 17, 2023
binmahone pushed a commit to apache/incubator-gluten that referenced this pull request Nov 17, 2023
* [GLUTEN-1632][CH]Daily Update Clickhouse Version (20231117)

* fix build due to ClickHouse/ClickHouse#56664

---------

Co-authored-by: kyligence-git <gluten@kyligence.io>
Co-authored-by: Chang Chen <baibaichen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants