Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pygithub #56778

Merged
merged 3 commits into from Nov 15, 2023
Merged

Fix pygithub #56778

merged 3 commits into from Nov 15, 2023

Conversation

Felixoid
Copy link
Member

@Felixoid Felixoid commented Nov 15, 2023 •
edited

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix issues with the changed PyGitHub API after updating it in #56459

@Felixoid Felixoid added pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Nov 15, 2023
Felixoid
Felixoid commented Nov 15, 2023
View reviewed changes
Copy link
Member Author

@Felixoid Felixoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test review

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 15, 2023
@robot-ch-test-poll1
Copy link
Contributor

robot-ch-test-poll1 commented Nov 15, 2023 •
edited by robot-clickhouse-ci-2

This is an automated comment for commit 30c6cea with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

@Felixoid
Copy link
Member Author

The merge_pr is fixed https://github.com/ClickHouse/ClickHouse/actions/runs/6875595452/job/18699494081?pr=56778

@Felixoid Felixoid removed pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Nov 15, 2023
@Felixoid Felixoid added the do not test disable testing on pull request label Nov 15, 2023
@Felixoid
Copy link
Member Author

The cherry_pick works too https://github.com/ClickHouse/ClickHouse/actions/runs/6875656445/job/18699683772#step:5:40

@Felixoid
Copy link
Member Author

Good that we test it actually https://github.com/ClickHouse/ClickHouse/actions/runs/6875694891/job/18700012395?pr=56778#step:4:40

Another broken place

Felixoid
Felixoid commented Nov 15, 2023
View reviewed changes
Copy link
Member Author

@Felixoid Felixoid left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another review test

and it works https://github.com/ClickHouse/ClickHouse/actions/runs/6875955795/job/18700589832?pr=56778#step:4:33

@Felixoid Felixoid merged commit 89dd479 into master Nov 15, 2023
103 of 104 checks passed
@Felixoid Felixoid deleted the fix-pygithub branch November 15, 2023 10:33
@Felixoid Felixoid added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Nov 21, 2023
@Felixoid
Copy link
Member Author

In the backport I'll cherry-pick https://github.com/ClickHouse/ClickHouse/pull/55845/files too

This was referenced Nov 21, 2023
Merged
Merged
Merged
Merged
robot-ch-test-poll2 added a commit that referenced this pull request Nov 21, 2023
@robot-ch-test-poll2
Merge pull request #57044 from ClickHouse/cherrypick/23.10/89dd479072…
4f36104 
…ff6eb65a3c125807d2aed4d422d83a

Cherry pick #56778 to 23.10: Fix pygithub
@robot-ch-test-poll2 robot-ch-test-poll2 mentioned this pull request Nov 21, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Nov 21, 2023
@robot-clickhouse
Backport #56778 to 23.10: Fix pygithub
34069ab
robot-ch-test-poll1 added a commit that referenced this pull request Nov 21, 2023
@robot-ch-test-poll1
Merge pull request #57041 from ClickHouse/cherrypick/23.3/89dd479072f…
ae924cc 
…f6eb65a3c125807d2aed4d422d83a

Cherry pick #56778 to 23.3: Fix pygithub
@robot-ch-test-poll1 robot-ch-test-poll1 mentioned this pull request Nov 21, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Nov 21, 2023
@robot-clickhouse
Backport #56778 to 23.3: Fix pygithub
24d4b56
robot-ch-test-poll1 added a commit that referenced this pull request Nov 21, 2023
@robot-ch-test-poll1
Merge pull request #57042 from ClickHouse/cherrypick/23.8/89dd479072f…
16c12d8 
…f6eb65a3c125807d2aed4d422d83a

Cherry pick #56778 to 23.8: Fix pygithub
@robot-ch-test-poll1 robot-ch-test-poll1 mentioned this pull request Nov 21, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Nov 21, 2023
@robot-clickhouse
Backport #56778 to 23.8: Fix pygithub
f2e9ee9
robot-ch-test-poll1 added a commit that referenced this pull request Nov 21, 2023
@robot-ch-test-poll1
Merge pull request #57043 from ClickHouse/cherrypick/23.9/89dd479072f…
020e6a6 
…f6eb65a3c125807d2aed4d422d83a

Cherry pick #56778 to 23.9: Fix pygithub
@robot-ch-test-poll1 robot-ch-test-poll1 mentioned this pull request Nov 21, 2023
Merged
robot-clickhouse added a commit that referenced this pull request Nov 21, 2023
@robot-clickhouse
Backport #56778 to 23.9: Fix pygithub
5aa3472
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Nov 21, 2023
Felixoid pushed a commit that referenced this pull request Nov 21, 2023
@nikitamikhaylov
Merge pull request #57057 from ClickHouse/backport/23.9/56778
5281a4a 
Backport #56778 to 23.9: Fix pygithub
Felixoid pushed a commit that referenced this pull request Nov 21, 2023
@nikitamikhaylov
Merge pull request #57045 from ClickHouse/backport/23.10/56778
6727cca 
Backport #56778 to 23.10: Fix pygithub
ch-devops pushed a commit to ClibMouse/ClickHouse that referenced this pull request Nov 22, 2023
@nikitamikhaylov
Merge pull request ClickHouse#57056 from ClickHouse/backport/23.8/56778
652e029 
Backport ClickHouse#56778 to 23.8: Fix pygithub
ch-devops pushed a commit to ClibMouse/ClickHouse that referenced this pull request Nov 22, 2023
@nikitamikhaylov
Merge pull request ClickHouse#57055 from ClickHouse/backport/23.3/56778
7293653 
Backport ClickHouse#56778 to 23.3: Fix pygithub
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonio2368 antonio2368 antonio2368 approved these changes

Assignees

@antonio2368 antonio2368

@nikitamikhaylov nikitamikhaylov

Labels
do not test disable testing on pull request pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Felixoid @robot-ch-test-poll1 @antonio2368 @nikitamikhaylov