Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better exception messages #56854

Merged
merged 1 commit into from Nov 16, 2023
Merged

Conversation

antonio2368
Copy link
Member

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Bad exception messages break 00002_log_and_exception_messages_formatting
cc @alexey-milovidov

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 16, 2023
@robot-ch-test-poll2
Copy link
Contributor

robot-ch-test-poll2 commented Nov 16, 2023

This is an automated comment for commit 504aeb9 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure

@hanfei1991 hanfei1991 self-assigned this Nov 16, 2023
@antonio2368 antonio2368 added pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Nov 16, 2023
@antonio2368 antonio2368 merged commit 147a04b into master Nov 16, 2023
316 of 331 checks passed
@antonio2368 antonio2368 deleted the make-exception-messages-better branch November 16, 2023 19:42
robot-ch-test-poll1 added a commit that referenced this pull request Nov 16, 2023
…d3fd649c0da1e5ba21d65e330ef24

Cherry pick #56854 to 23.3: Better exception messages
robot-ch-test-poll1 added a commit that referenced this pull request Nov 16, 2023
…d3fd649c0da1e5ba21d65e330ef24

Cherry pick #56854 to 23.8: Better exception messages
robot-ch-test-poll1 added a commit that referenced this pull request Nov 16, 2023
…d3fd649c0da1e5ba21d65e330ef24

Cherry pick #56854 to 23.9: Better exception messages
robot-ch-test-poll1 added a commit that referenced this pull request Nov 16, 2023
…cd3fd649c0da1e5ba21d65e330ef24

Cherry pick #56854 to 23.10: Better exception messages
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Nov 16, 2023
alexey-milovidov added a commit that referenced this pull request Nov 16, 2023
Backport #56854 to 23.8: Better exception messages
alexey-milovidov added a commit that referenced this pull request Nov 16, 2023
Backport #56854 to 23.9: Better exception messages
alexey-milovidov added a commit that referenced this pull request Nov 16, 2023
Backport #56854 to 23.10: Better exception messages
alexey-milovidov added a commit that referenced this pull request Nov 16, 2023
Backport #56854 to 23.3: Better exception messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants