New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tiny improvement security #57171
Tiny improvement security #57171
Conversation
This is an automated comment for commit dce47b4 with description of existing statuses. It's updated for the latest CI running ✅ Click here to open a full report in a separate page Successful checks
|
47323b3
to
de184b6
Compare
SECURITY.md
Outdated
@@ -21,8 +21,7 @@ The following versions of ClickHouse server are currently being supported with s | |||
| 23.5 | ❌ | | |||
| 23.4 | ❌ | | |||
| 23.3 | ✔️ | | |||
| 23.2 | ❌ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes it ambiguous.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so, when 23.8
will remain the last supported version in 23, it's better to have all the rest of the year? That's the current logic, and we can leave it as it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. No ambiguity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll then only improve readability
@Felixoid If you say "23.3 is supported" and "23.* is unsupported" it is controversial, it can be put out of context, and generally not good. Being as precise as possible is better. |
de184b6
to
fdda1e6
Compare
Sure, I've brought them back. I meant the script readability. As well, I'll backport it to release branches to have |
fdda1e6
to
ee51402
Compare
ee51402
to
dce47b4
Compare
It's checked by style check, and I've tested all docker images from this branches for tags from 22.3.20.29 to 23.10.4.25 |
…6906e2e0f8ae6de7e6ac83e57890e Cherry pick #57171 to 23.8: Tiny improvement security
…6906e2e0f8ae6de7e6ac83e57890e Cherry pick #57171 to 23.9: Tiny improvement security
…36906e2e0f8ae6de7e6ac83e57890e Cherry pick #57171 to 23.10: Tiny improvement security
…6906e2e0f8ae6de7e6ac83e57890e Cherry pick #57171 to 23.3: Tiny improvement security
Backport ClickHouse#57171 to 23.8: Tiny improvement security
Backport ClickHouse#57171 to 23.3: Tiny improvement security
Backport ClickHouse#57171 to 23.9: Tiny improvement security
Backport ClickHouse#57171 to 23.10: Tiny improvement security
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
A tiny improvement to SECURITY.md