Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny improvement security #57171

Merged
merged 2 commits into from Nov 24, 2023
Merged

Tiny improvement security #57171

merged 2 commits into from Nov 24, 2023

Conversation

Felixoid
Copy link
Member

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

A tiny improvement to SECURITY.md

@Felixoid Felixoid added the do not test disable testing on pull request label Nov 23, 2023
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 23, 2023
@robot-clickhouse-ci-1
Copy link
Contributor

robot-clickhouse-ci-1 commented Nov 23, 2023

This is an automated comment for commit dce47b4 with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

@Felixoid Felixoid force-pushed the tiny-improvement-security branch 3 times, most recently from 47323b3 to de184b6 Compare November 23, 2023 21:38
SECURITY.md Outdated
@@ -21,8 +21,7 @@ The following versions of ClickHouse server are currently being supported with s
| 23.5 | ❌ |
| 23.4 | ❌ |
| 23.3 | ✔️ |
| 23.2 | ❌ |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes it ambiguous.

Copy link
Member Author

@Felixoid Felixoid Nov 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, when 23.8 will remain the last supported version in 23, it's better to have all the rest of the year? That's the current logic, and we can leave it as it is.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. No ambiguity.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll then only improve readability

@Felixoid Felixoid reopened this Nov 24, 2023
@Felixoid Felixoid marked this pull request as draft November 24, 2023 14:42
@alexey-milovidov
Copy link
Member

@Felixoid If you say "23.3 is supported" and "23.* is unsupported" it is controversial, it can be put out of context, and generally not good. Being as precise as possible is better.

@Felixoid Felixoid marked this pull request as ready for review November 24, 2023 19:15
@Felixoid Felixoid added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Nov 24, 2023
@Felixoid
Copy link
Member Author

Sure, I've brought them back. I meant the script readability.

As well, I'll backport it to release branches to have .dockerignore removed there. It's necessary for #31473

@Felixoid
Copy link
Member Author

It's checked by style check, and I've tested all docker images from this branches for tags from 22.3.20.29 to 23.10.4.25

@Felixoid Felixoid merged commit ec18f24 into master Nov 24, 2023
97 of 100 checks passed
@Felixoid Felixoid deleted the tiny-improvement-security branch November 24, 2023 19:34
robot-ch-test-poll3 added a commit that referenced this pull request Nov 24, 2023
…6906e2e0f8ae6de7e6ac83e57890e

Cherry pick #57171 to 23.8: Tiny improvement security
robot-ch-test-poll3 added a commit that referenced this pull request Nov 24, 2023
…6906e2e0f8ae6de7e6ac83e57890e

Cherry pick #57171 to 23.9: Tiny improvement security
robot-ch-test-poll3 added a commit that referenced this pull request Nov 24, 2023
…36906e2e0f8ae6de7e6ac83e57890e

Cherry pick #57171 to 23.10: Tiny improvement security
robot-ch-test-poll2 added a commit that referenced this pull request Nov 24, 2023
…6906e2e0f8ae6de7e6ac83e57890e

Cherry pick #57171 to 23.3: Tiny improvement security
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Nov 24, 2023
ch-devops pushed a commit to ClibMouse/ClickHouse that referenced this pull request Nov 25, 2023
ch-devops pushed a commit to ClibMouse/ClickHouse that referenced this pull request Nov 25, 2023
ch-devops pushed a commit to ClibMouse/ClickHouse that referenced this pull request Nov 25, 2023
ch-devops pushed a commit to ClibMouse/ClickHouse that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not test disable testing on pull request pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants