Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate LIVE VIEW #57706

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Deprecate LIVE VIEW #57706

merged 1 commit into from
Dec 9, 2023

Conversation

alexey-milovidov
Copy link
Member

Changelog category (leave one):

  • Documentation (changelog entry is not required)

@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-documentation Documentation PRs for the specific code PR label Dec 9, 2023
@robot-ch-test-poll3
Copy link
Contributor

robot-ch-test-poll3 commented Dec 9, 2023

This is an automated comment for commit 0d1bdff with description of existing statuses. It's updated for the latest CI running

✅ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
Docs CheckBuilds and tests the documentation✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success

@alexey-milovidov alexey-milovidov self-assigned this Dec 9, 2023
@alexey-milovidov alexey-milovidov merged commit 7e61bce into master Dec 9, 2023
18 checks passed
@alexey-milovidov alexey-milovidov deleted the deprecate-live-view-2 branch December 9, 2023 16:43
@azat
Copy link
Collaborator

azat commented Dec 9, 2023

I would say that changelog entry is useful for this change (even though the code is still there), maybe this will force creators to fix all the bugs in LIVE VIEW to make it upstream ready

P.S. I'm using them to monitor changes to system tables with statistics

@vzakaznikov
Copy link
Contributor

I might be mistaken, but the last time I've reviewed issues related to Live Views I did not spot anything specific to Live View code.
Live Views are using internal pipeline code so when some type of query is not working the fix has to go into the query pipeline.

@vzakaznikov
Copy link
Contributor

As far as the support for this feature in general. Here is a related comment #39638 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-documentation Documentation PRs for the specific code PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants