Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker image for integration tests (fixes CI) #57952

Merged
merged 1 commit into from Dec 17, 2023

Conversation

azat
Copy link
Collaborator

@azat azat commented Dec 16, 2023

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

CI: https://s3.amazonaws.com/clickhouse-test-reports/57951/5e5bdfe4e8071a5e1f867d186adf9b5675e3c597/integration_tests__asan__analyzer__[3_6].html

Actually it is any integration tests jobs on CI

2023-12-16 19:01:22 [ 574 ] DEBUG : Command:['docker-compose', '--env-file', '/ClickHouse/tests/integration/test_atomic_drop_table/_instances_0/.env', '--project-name', 'roottestatomicdroptable', '--file', '/ClickHouse/tests/integration/test_atomic_drop_table/_instances_0/node1/docker-compose.yml', '--file', '/compose/docker_compose_keeper.yml', 'pull'] (cluster.py:103, run_and_check)
2023-12-16 19:01:22 [ 574 ] DEBUG : Stderr:Traceback (most recent call last): (cluster.py:113, run_and_check)
2023-12-16 19:01:22 [ 574 ] DEBUG : Stderr:  File "/usr/local/bin/docker-compose", line 8, in <module> (cluster.py:113, run_and_check)
2023-12-16 19:01:22 [ 574 ] DEBUG : Stderr:    sys.exit(main()) (cluster.py:113, run_and_check)
2023-12-16 19:01:22 [ 574 ] DEBUG : Stderr:  File "/usr/local/lib/python3.10/dist-packages/compose/cli/main.py", line 81, in main (cluster.py:113, run_and_check)
2023-12-16 19:01:22 [ 574 ] DEBUG : Stderr:    command_func() (cluster.py:113, run_and_check)
2023-12-16 19:01:22 [ 574 ] DEBUG : Stderr:  File "/usr/local/lib/python3.10/dist-packages/compose/cli/main.py", line 200, in perform_command (cluster.py:113, run_and_check)
2023-12-16 19:01:22 [ 574 ] DEBUG : Stderr:    project = project_from_options('.', options) (cluster.py:113, run_and_check)
2023-12-16 19:01:22 [ 574 ] DEBUG : Stderr:  File "/usr/local/lib/python3.10/dist-packages/compose/cli/command.py", line 60, in project_from_options (cluster.py:113, run_and_check)
2023-12-16 19:01:22 [ 574 ] DEBUG : Stderr:    return get_project( (cluster.py:113, run_and_check)
2023-12-16 19:01:22 [ 574 ] DEBUG : Stderr:  File "/usr/local/lib/python3.10/dist-packages/compose/cli/command.py", line 152, in get_project (cluster.py:113, run_and_check)
2023-12-16 19:01:22 [ 574 ] DEBUG : Stderr:    client = get_client( (cluster.py:113, run_and_check)
2023-12-16 19:01:22 [ 574 ] DEBUG : Stderr:  File "/usr/local/lib/python3.10/dist-packages/compose/cli/docker_client.py", line 41, in get_client (cluster.py:113, run_and_check)
2023-12-16 19:01:22 [ 574 ] DEBUG : Stderr:    client = docker_client( (cluster.py:113, run_and_check)
2023-12-16 19:01:22 [ 574 ] DEBUG : Stderr:  File "/usr/local/lib/python3.10/dist-packages/compose/cli/docker_client.py", line 124, in docker_client (cluster.py:113, run_and_check)
2023-12-16 19:01:22 [ 574 ] DEBUG : Stderr:    kwargs = kwargs_from_env(environment=environment, ssl_version=tls_version) (cluster.py:113, run_and_check)
2023-12-16 19:01:22 [ 574 ] DEBUG : Stderr:TypeError: kwargs_from_env() got an unexpected keyword argument 'ssl_version' (cluster.py:113, run_and_check)
2023-12-16 19:01:22 [ 574 ] DEBUG : Exitcode:1 (cluster.py:115, run_and_check)
2023-12-16 19:01:22 [ 574 ] INFO : Got exception pulling images: Command ['docker-compose', '--env-file', '/ClickHouse/tests/integration/test_atomic_drop_table/_instances_0/.env', '--project-name', 'roottestatomicdroptable', '--file', '/ClickHouse/tests/integration/test_atomic_drop_table/_instances_0/node1/docker-compose.yml', '--file', '/compose/docker_compose_keeper.yml', 'pull'] return non-zero code 1: Traceback (most recent call last):
  File "/usr/local/bin/docker-compose", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.10/dist-packages/compose/cli/main.py", line 81, in main
    command_func()
  File "/usr/local/lib/python3.10/dist-packages/compose/cli/main.py", line 200, in perform_command
    project = project_from_options('.', options)
  File "/usr/local/lib/python3.10/dist-packages/compose/cli/command.py", line 60, in project_from_options
    return get_project(
  File "/usr/local/lib/python3.10/dist-packages/compose/cli/command.py", line 152, in get_project
    client = get_client(
  File "/usr/local/lib/python3.10/dist-packages/compose/cli/docker_client.py", line 41, in get_client
    client = docker_client(
  File "/usr/local/lib/python3.10/dist-packages/compose/cli/docker_client.py", line 124, in docker_client
    kwargs = kwargs_from_env(environment=environment, ssl_version=tls_version)
TypeError: kwargs_from_env() got an unexpected keyword argument 'ssl_version'

Let's just pin the docker library to the latest worked version (though the problem is likely due to docker-compose pip package is pinned, while docker wasn't)

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Dec 16, 2023
@robot-clickhouse-ci-2
Copy link
Contributor

robot-clickhouse-ci-2 commented Dec 16, 2023

This is an automated comment for commit 60bf2a4 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure

@azat
Copy link
Collaborator Author

azat commented Dec 16, 2023

Looks like does works - https://github.com/ClickHouse/ClickHouse/actions/runs/7234202245/job/19710868979?pr=57952:

2023-12-16 22:08:53,014 Tests with PASSED state (2): ['test_crash_log/test.py::test_pkill_query_log', 'test_crash_log/test.py::test_pkill']
...
2023-12-16 22:08:53,028 Totally finished tests 4/661

@alexey-milovidov alexey-milovidov self-assigned this Dec 17, 2023
@alexey-milovidov alexey-milovidov merged commit 32d73a0 into ClickHouse:master Dec 17, 2023
311 of 344 checks passed
@alexey-milovidov
Copy link
Member

Thank you! Just in case, can we pin all the libraries?

I'm trying to convince @Felixoid that we should always pin everything, but not successful so far:
#51682 (comment)

In my opinion, allowing anything to update on its own is just complete insanity.

@alexey-milovidov alexey-milovidov added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Dec 17, 2023
robot-ch-test-poll1 added a commit that referenced this pull request Dec 17, 2023
…530812981f50afc0d4598f47828de

Cherry pick #57952 to 23.3: Fix docker image for integration tests (fixes CI)
robot-ch-test-poll1 added a commit that referenced this pull request Dec 17, 2023
…530812981f50afc0d4598f47828de

Cherry pick #57952 to 23.8: Fix docker image for integration tests (fixes CI)
robot-ch-test-poll1 added a commit that referenced this pull request Dec 17, 2023
…530812981f50afc0d4598f47828de

Cherry pick #57952 to 23.9: Fix docker image for integration tests (fixes CI)
robot-ch-test-poll1 added a commit that referenced this pull request Dec 17, 2023
…a530812981f50afc0d4598f47828de

Cherry pick #57952 to 23.10: Fix docker image for integration tests (fixes CI)
robot-ch-test-poll1 added a commit that referenced this pull request Dec 17, 2023
…a530812981f50afc0d4598f47828de

Cherry pick #57952 to 23.11: Fix docker image for integration tests (fixes CI)
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Dec 17, 2023
alexey-milovidov added a commit that referenced this pull request Dec 17, 2023
Backport #57952 to 23.8: Fix docker image for integration tests (fixes CI)
alexey-milovidov added a commit that referenced this pull request Dec 17, 2023
Backport #57952 to 23.9: Fix docker image for integration tests (fixes CI)
alexey-milovidov added a commit that referenced this pull request Dec 17, 2023
Backport #57952 to 23.10: Fix docker image for integration tests (fixes CI)
alexey-milovidov added a commit that referenced this pull request Dec 17, 2023
Backport #57952 to 23.11: Fix docker image for integration tests (fixes CI)
alexey-milovidov added a commit that referenced this pull request Dec 17, 2023
Backport #57952 to 23.3: Fix docker image for integration tests (fixes CI)
@azat azat deleted the ci/fix-integration-tests branch December 17, 2023 08:09
@azat
Copy link
Collaborator Author

azat commented Dec 17, 2023

Just in case, can we pin all the libraries?

The idea from #51682, sounds like a perfect choice:

Here it is. Now we have a nightly update everything task, that just does it. The proposal is to replace it with nightly creation PRs to have the CI finished with updated images.

@alexey-milovidov
Copy link
Member

Yes, but I want something to apply immediately, not handwaving...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants