New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix possible race in ManyAggregatedData dtor. #58624
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KochetovNicolai
added
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-must-backport-cloud
labels
Jan 9, 2024
robot-ch-test-poll3
added
the
pr-not-for-changelog
This PR should not be mentioned in the changelog
label
Jan 9, 2024
This is an automated comment for commit 53d24af with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
novikd
approved these changes
Jan 10, 2024
alexey-milovidov
approved these changes
Jan 10, 2024
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
Jan 10, 2024
…462b96401f18a267eebeefb693125 Cherry pick #58624 to 23.3: Fix possible race in ManyAggregatedData dtor.
robot-clickhouse
added a commit
that referenced
this pull request
Jan 10, 2024
This was referenced Jan 10, 2024
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
Jan 10, 2024
…462b96401f18a267eebeefb693125 Cherry pick #58624 to 23.8: Fix possible race in ManyAggregatedData dtor.
robot-clickhouse
added a commit
that referenced
this pull request
Jan 10, 2024
This was referenced Jan 10, 2024
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
Jan 10, 2024
…6462b96401f18a267eebeefb693125 Cherry pick #58624 to 23.10: Fix possible race in ManyAggregatedData dtor.
robot-clickhouse
added a commit
that referenced
this pull request
Jan 10, 2024
This was referenced Jan 10, 2024
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
Jan 10, 2024
…6462b96401f18a267eebeefb693125 Cherry pick #58624 to 23.11: Fix possible race in ManyAggregatedData dtor.
robot-clickhouse
added a commit
that referenced
this pull request
Jan 10, 2024
This was referenced Jan 10, 2024
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
Jan 10, 2024
…6462b96401f18a267eebeefb693125 Cherry pick #58624 to 23.12: Fix possible race in ManyAggregatedData dtor.
robot-clickhouse
added a commit
that referenced
this pull request
Jan 10, 2024
robot-clickhouse-ci-2
added
the
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
label
Jan 10, 2024
robot-clickhouse
added a commit
that referenced
this pull request
Jan 11, 2024
Backport #58624 to 23.12: Fix possible race in ManyAggregatedData dtor.
alexey-milovidov
added a commit
that referenced
this pull request
Jan 13, 2024
Backport #58624 to 23.8: Fix possible race in ManyAggregatedData dtor.
alexey-milovidov
added a commit
that referenced
this pull request
Jan 13, 2024
Backport #58624 to 23.10: Fix possible race in ManyAggregatedData dtor.
alexey-milovidov
added a commit
that referenced
this pull request
Jan 13, 2024
Backport #58624 to 23.11: Fix possible race in ManyAggregatedData dtor.
alexey-milovidov
added a commit
that referenced
this pull request
Jan 13, 2024
Backport #58624 to 23.3: Fix possible race in ManyAggregatedData dtor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-backports-created-cloud
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-must-backport-cloud
pr-not-for-changelog
This PR should not be mentioned in the changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix possible race in
ManyAggregatedData
dtor. Fixes #58437ManyAggregatedData
containsvariants
which isstd::vector<AggregatedDataVariantsPtr>
.~ManyAggregatedData
is optimized to destroy variants in multiple threads if needed, but does not check if ref count for a variant. Another copy ofManyAggregatedData
was created, so the ref count could be > 1 in dtor.Note: this race is harmless. The only possible difference could be in the number of threads created in
~ManyAggregatedData
.