-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to fix logical error 'Cannot capture column because it has incompatible type' in mapContainsKeyLike #60451
Conversation
…atible type' in mapContainsKeyLike
column_tuple->getColumnPtr(j), | ||
recursiveRemoveLowCardinality(type_tuple.getElement(j)), | ||
type_tuple.getElement(j), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't understand why we remove LowCardinality recursively here from data type only, so the column may remain LowCardinality. Don't see why we need to remove LowCardinality here at all, let's check if some tests will fail
This is an automated comment for commit 47ad21d with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
No tests failed, seems ok |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix logical error 'Cannot capture column because it has incompatible type' in mapContainsKeyLike
Documentation entry for user-facing changes