Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use clang-18 in CI #60469

Merged
merged 60 commits into from
May 13, 2024
Merged

Use clang-18 in CI #60469

merged 60 commits into from
May 13, 2024

Conversation

alexey-milovidov
Copy link
Member

@alexey-milovidov alexey-milovidov commented Feb 27, 2024

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

ClickHouse is built with clang-18. A lot of new checks from clang-tidy-18 have been enabled.

@alexey-milovidov alexey-milovidov added the pr-performance-tests Forces full performance tests in CI label Feb 27, 2024
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-build Pull request with build/testing/packaging improvement label Feb 27, 2024
@robot-ch-test-poll1
Copy link
Contributor

robot-ch-test-poll1 commented Feb 27, 2024

This is an automated comment for commit 4eb42bb with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@qoega
Copy link
Member

qoega commented Feb 28, 2024

Many new crashes:

/build/src/Compression/CompressionCodecDoubleDelta.cpp:346:76: runtime error: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself
    #0 0x55a5527297f5 in unsigned int DB::(anonymous namespace)::compressDataForType<unsigned int>(char const*, unsigned int, char*) build_docker/./src/Compression/CompressionCodecDoubleDelta.cpp:346:67
    #1 0x55a5527297f5 in DB::CompressionCodecDoubleDelta::doCompressData(char const*, unsigned int, char*) const build_docker/./src/Compression/CompressionCodecDoubleDelta.cpp:501:27
    #2 0x55a5527502ab in DB::ICompressionCodec::compress(char const*, unsigned int, char*) const build_docker/./src/Compression/ICompressionCodec.cpp:86:39
    #3 0x55a53f4c126a in void (anonymous namespace)::testTranscoding<(anonymous namespace)::NoOpTimer>((anonymous namespace)::NoOpTimer&, DB::ICompressionCodec&, (anonymous namespace)::CodecTestSequence const&, std::__1::optional<double>) build_docker/./src/Compression/tests/gtest_compressionCodec.cpp:469:39
    #4 0x55a53f4c126a in (anonymous namespace)::CodecTest::testTranscoding(DB::ICompressionCodec&) build_docker/./src/Compression/tests/gtest_compressionCodec.cpp:518:9
    #5 0x55a53f4c126a in (anonymous namespace)::CodecTest_TranscodingWithDataType_Test::TestBody() build_docker/./src/Compression/tests/gtest_compressionCodec.cpp:532:5
    #6 0x55a54bdc3070 in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) build_docker/./contrib/googletest/googletest/src/gtest.cc:2612:10
    #7 0x55a54bdc3070 in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) build_docker/./contrib/googletest/googletest/src/gtest.cc:2648:14
    #8 0x55a54bdc2f58 in testing::Test::Run() build_docker/./contrib/googletest/googletest/src/gtest.cc:2687:5
    #9 0x55a54bdc44e1 in testing::TestInfo::Run() build_docker/./contrib/googletest/googletest/src/gtest.cc:2836:11
    #10 0x55a54bdc55f4 in testing::TestSuite::Run() build_docker/./contrib/googletest/googletest/src/gtest.cc:3015:30
    #11 0x55a54bdd68cd in testing::internal::UnitTestImpl::RunAllTests() build_docker/./contrib/googletest/googletest/src/gtest.cc:5921:44
    #12 0x55a54bdd62b0 in bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) build_docker/./contrib/googletest/googletest/src/gtest.cc:2612:10
    #13 0x55a54bdd62b0 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) build_docker/./contrib/googletest/googletest/src/gtest.cc:2648:14
    #14 0x55a54bdd6126 in testing::UnitTest::Run() build_docker/./contrib/googletest/googletest/src/gtest.cc:5485:10
    #15 0x55a53f3e9f0d in RUN_ALL_TESTS() build_docker/./contrib/googletest/googletest/include/gtest/gtest.h:2316:73
    #16 0x55a53f3e9f0d in main build_docker/./src/Common/tests/gtest_main.cpp:17:12
    #17 0x7f3e07723d8f  (/lib/x86_64-linux-gnu/libc.so.6+0x29d8f) (BuildId: c289da5071a3399de893d2af81d6a30c62646e1e)
    #18 0x7f3e07723e3f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x29e3f) (BuildId: c289da5071a3399de893d2af81d6a30c62646e1e)
    #19 0x55a53f0700ed in _start (/unit_tests_dbms+0x182810ed) (BuildId: 3d46fcdc80582dbe6d3c3916a0377dc283d9153b)

SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /build/src/Compression/CompressionCodecDoubleDelta.cpp:346:76 ```

@rschu1ze

This comment was marked as outdated.

@nikitamikhaylov nikitamikhaylov self-assigned this Apr 25, 2024
@rschu1ze rschu1ze mentioned this pull request Apr 30, 2024
30 tasks
@alexey-milovidov
Copy link
Member Author

RabbitMQ has a bug.

@alexey-milovidov
Copy link
Member Author

clang-tidy has a bug: llvm/llvm-project#91872

@alexey-milovidov
Copy link
Member Author

#63672

@alexey-milovidov alexey-milovidov merged commit f27a0d6 into master May 13, 2024
191 of 213 checks passed
@alexey-milovidov alexey-milovidov deleted the clang-18-ci branch May 13, 2024 07:35
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label May 13, 2024
baibaichen pushed a commit to apache/incubator-gluten that referenced this pull request May 14, 2024
Co-authored-by: kyligence-git <gluten@kyligence.io>
We need merge due to ClickHouse/ClickHouse#60469
@rschu1ze rschu1ze mentioned this pull request May 19, 2024
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build Pull request with build/testing/packaging improvement pr-performance-tests Forces full performance tests in CI pr-synced-to-cloud The PR is synced to the cloud repo submodule changed At least one submodule changed in this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants