Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when using input() in INSERT SELECT JOIN #60765

Merged
merged 2 commits into from Mar 5, 2024

Conversation

Avogar
Copy link
Member

@Avogar Avogar commented Mar 4, 2024

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix crash when using input() in INSERT SELECT JOIN. Closes #60035

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-bugfix Pull request with bugfix, not backported by default label Mar 4, 2024
@robot-ch-test-poll1
Copy link
Contributor

robot-ch-test-poll1 commented Mar 4, 2024

This is an automated comment for commit d7de634 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS⏳ pending
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure

@@ -1790,7 +1790,7 @@ StoragePtr Context::executeTableFunction(const ASTPtr & table_expression, const
}

uint64_t use_structure_from_insertion_table_in_table_functions = getSettingsRef().use_structure_from_insertion_table_in_table_functions;
if (use_structure_from_insertion_table_in_table_functions && table_function_ptr->needStructureHint() && hasInsertionTable())
if (select_query_hint && use_structure_from_insertion_table_in_table_functions && table_function_ptr->needStructureHint() && hasInsertionTable())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably some comment would be helpful.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the condition is self-describing, if use_structure_from_insertion_table_in_table_functions is enabled, table function needs structure hint and we have both insertion table and select query, we go to the logic of using structure from insertion table in table function. Previously we just didn't check that we actually have select query AST (it could be nullptr).
I can write it in a comment, but imo it will just repeat what is written in the condition. Maybe I just don't see what part is confusing and requires a comment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is new code to me, I need more context to get it straight. One way to simplify the complex condition is to assign it to a variable with a self-explanatory name. Probably, it can help

@alexey-milovidov alexey-milovidov merged commit 8aeffa0 into ClickHouse:master Mar 5, 2024
243 of 246 checks passed
@alexey-milovidov alexey-milovidov added pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Mar 5, 2024
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 5, 2024
robot-clickhouse-ci-2 added a commit that referenced this pull request Mar 5, 2024
…e31da7228fcb09f17e5bf7411cac8

Cherry pick #60765 to 23.8: Fix crash when using input() in INSERT SELECT JOIN
robot-clickhouse-ci-2 added a commit that referenced this pull request Mar 5, 2024
…de31da7228fcb09f17e5bf7411cac8

Cherry pick #60765 to 23.12: Fix crash when using input() in INSERT SELECT JOIN
robot-clickhouse-ci-2 added a commit that referenced this pull request Mar 5, 2024
…e31da7228fcb09f17e5bf7411cac8

Cherry pick #60765 to 24.1: Fix crash when using input() in INSERT SELECT JOIN
robot-clickhouse-ci-2 added a commit that referenced this pull request Mar 5, 2024
…e31da7228fcb09f17e5bf7411cac8

Cherry pick #60765 to 24.2: Fix crash when using input() in INSERT SELECT JOIN
alexey-milovidov added a commit that referenced this pull request Mar 5, 2024
Backport #60765 to 24.1: Fix crash when using input() in INSERT SELECT JOIN
alexey-milovidov added a commit that referenced this pull request Mar 5, 2024
Backport #60765 to 24.2: Fix crash when using input() in INSERT SELECT JOIN
alexey-milovidov added a commit that referenced this pull request Mar 5, 2024
Backport #60765 to 23.12: Fix crash when using input() in INSERT SELECT JOIN
Avogar added a commit that referenced this pull request Mar 6, 2024
Backport #60765 to 23.8: Fix crash when using input() in INSERT SELECT JOIN
robot-ch-test-poll1 added a commit that referenced this pull request Mar 6, 2024
…e31da7228fcb09f17e5bf7411cac8

Cherry pick #60765 to 23.3: Fix crash when using input() in INSERT SELECT JOIN
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Mar 6, 2024
alexey-milovidov added a commit that referenced this pull request Mar 6, 2024
Backport #60765 to 23.3: Fix crash when using input() in INSERT SELECT JOIN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

server crash on excessive ) at the end of insert query
6 participants