Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove recursion when reading from S3 #60849

Merged
merged 1 commit into from Mar 6, 2024
Merged

Conversation

antonio2368
Copy link
Member

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Avoid segfault if too many keys are skipped when reading from S3.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-bugfix Pull request with bugfix, not backported by default label Mar 5, 2024
@robot-ch-test-poll3
Copy link
Contributor

robot-ch-test-poll3 commented Mar 5, 2024

This is an automated comment for commit 0bd4c6a with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
Bugfix validationChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch❌ failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure

@Avogar Avogar self-assigned this Mar 5, 2024
src/Storages/StorageS3.cpp Outdated Show resolved Hide resolved
@antonio2368 antonio2368 changed the title Check for stacksize when reading from S3 Remove recursion when reading from S3 Mar 5, 2024
@antonio2368 antonio2368 requested a review from Avogar March 5, 2024 10:57
@antonio2368 antonio2368 added pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Mar 5, 2024
@alexey-milovidov alexey-milovidov self-assigned this Mar 5, 2024
@antonio2368 antonio2368 merged commit a39c00a into master Mar 6, 2024
241 of 251 checks passed
@antonio2368 antonio2368 deleted the avoid-stackoverflow-s3 branch March 6, 2024 07:51
robot-ch-test-poll2 added a commit that referenced this pull request Mar 6, 2024
…080824fddc3eec5042b9e8ba405d76

Cherry pick #60849 to 23.12: Remove recursion when reading from S3
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 6, 2024
robot-ch-test-poll2 added a commit that referenced this pull request Mar 6, 2024
…80824fddc3eec5042b9e8ba405d76

Cherry pick #60849 to 24.1: Remove recursion when reading from S3
robot-ch-test-poll2 added a commit that referenced this pull request Mar 6, 2024
…80824fddc3eec5042b9e8ba405d76

Cherry pick #60849 to 24.2: Remove recursion when reading from S3
robot-clickhouse-ci-2 added a commit that referenced this pull request Mar 6, 2024
…80824fddc3eec5042b9e8ba405d76

Cherry pick #60849 to 23.3: Remove recursion when reading from S3
robot-clickhouse-ci-2 added a commit that referenced this pull request Mar 6, 2024
…80824fddc3eec5042b9e8ba405d76

Cherry pick #60849 to 23.8: Remove recursion when reading from S3
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Mar 6, 2024
robot-ch-test-poll4 added a commit that referenced this pull request Mar 6, 2024
Backport #60849 to 24.1: Remove recursion when reading from S3
antonio2368 added a commit that referenced this pull request Mar 6, 2024
Backport #60849 to 23.12: Remove recursion when reading from S3
antonio2368 added a commit that referenced this pull request Mar 6, 2024
Backport #60849 to 24.2: Remove recursion when reading from S3
antonio2368 added a commit that referenced this pull request Mar 6, 2024
Backport #60849 to 23.3: Remove recursion when reading from S3
antonio2368 added a commit that referenced this pull request Mar 6, 2024
Backport #60849 to 23.8: Remove recursion when reading from S3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants