New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove recursion when reading from S3 #60849
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll3
added
the
pr-bugfix
Pull request with bugfix, not backported by default
label
Mar 5, 2024
This is an automated comment for commit 0bd4c6a with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
Avogar
reviewed
Mar 5, 2024
antonio2368
force-pushed
the
avoid-stackoverflow-s3
branch
from
March 5, 2024 10:55
8c1813f
to
0bd4c6a
Compare
antonio2368
changed the title
Check for stacksize when reading from S3
Remove recursion when reading from S3
Mar 5, 2024
antonio2368
added
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-must-backport-cloud
labels
Mar 5, 2024
Avogar
approved these changes
Mar 5, 2024
alexey-milovidov
approved these changes
Mar 5, 2024
This was referenced Mar 6, 2024
robot-ch-test-poll2
added a commit
that referenced
this pull request
Mar 6, 2024
…080824fddc3eec5042b9e8ba405d76 Cherry pick #60849 to 23.12: Remove recursion when reading from S3
robot-clickhouse
added a commit
that referenced
this pull request
Mar 6, 2024
This was referenced Mar 6, 2024
robot-ch-test-poll2
added a commit
that referenced
this pull request
Mar 6, 2024
…80824fddc3eec5042b9e8ba405d76 Cherry pick #60849 to 24.1: Remove recursion when reading from S3
robot-clickhouse
added a commit
that referenced
this pull request
Mar 6, 2024
This was referenced Mar 6, 2024
robot-ch-test-poll2
added a commit
that referenced
this pull request
Mar 6, 2024
…80824fddc3eec5042b9e8ba405d76 Cherry pick #60849 to 24.2: Remove recursion when reading from S3
robot-clickhouse
added a commit
that referenced
this pull request
Mar 6, 2024
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
Mar 6, 2024
…80824fddc3eec5042b9e8ba405d76 Cherry pick #60849 to 23.3: Remove recursion when reading from S3
robot-clickhouse
added a commit
that referenced
this pull request
Mar 6, 2024
robot-clickhouse-ci-2
added a commit
that referenced
this pull request
Mar 6, 2024
…80824fddc3eec5042b9e8ba405d76 Cherry pick #60849 to 23.8: Remove recursion when reading from S3
robot-clickhouse
added a commit
that referenced
this pull request
Mar 6, 2024
robot-clickhouse-ci-2
added
the
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
label
Mar 6, 2024
robot-ch-test-poll4
added a commit
that referenced
this pull request
Mar 6, 2024
Backport #60849 to 24.1: Remove recursion when reading from S3
antonio2368
added a commit
that referenced
this pull request
Mar 6, 2024
Backport #60849 to 23.12: Remove recursion when reading from S3
antonio2368
added a commit
that referenced
this pull request
Mar 6, 2024
Backport #60849 to 24.2: Remove recursion when reading from S3
antonio2368
added a commit
that referenced
this pull request
Mar 6, 2024
Backport #60849 to 23.3: Remove recursion when reading from S3
antonio2368
added a commit
that referenced
this pull request
Mar 6, 2024
Backport #60849 to 23.8: Remove recursion when reading from S3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-backports-created
Backport PRs are successfully created, it won't be processed by CI script anymore
pr-backports-created-cloud
pr-bugfix
Pull request with bugfix, not backported by default
pr-must-backport
Pull request should be backported intentionally. Use this label with great care!
pr-must-backport-cloud
pr-synced-to-cloud
The PR is synced to the cloud repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Avoid segfault if too many keys are skipped when reading from S3.
Documentation entry for user-facing changes