-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs to simplejson and sin #60881
Conversation
This is an automated comment for commit 61c3d91 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
Let's also copy to inline docs... |
src/Common/FunctionDocumentation.cpp
Outdated
@@ -36,6 +36,7 @@ std::string FunctionDocumentation::categoriesAsString() const | |||
|
|||
auto it = categories.begin(); | |||
std::string res = *it; | |||
++it; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe replace l. 34-42 by return boost::algorithms::join(categories, ", ")
?
Test failures are not related. |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add documentation to
simpleJSON
functions, unify documentation forvisitParam
functions and add example tosin
.Documentation entry for user-facing changes