Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryFuzzer: replace element randomly when AST part buffer is full #61124

Conversation

tomershafir
Copy link
Contributor

@tomershafir tomershafir commented Mar 9, 2024

Addressing a TODO:

 * TODO: we just stop remembering new parts after our corpus reaches certain size.
 * This is boring, should implement a random replacement of existing parst with
 * small probability. Do this after we add this fuzzer to CI and fix all the
 * problems it can routinely find even in this boring version.

I did a simple series of regression testing roughly comparing results of the following between old and new versions:

./build/programs/clickhouse client --query-fuzzer-runs 100 -q "SELECT (val + 257, (((tuple(NULL), 10.000100135803223), tuple(-inf)), '-1', (NULL, '0.10', NULL), NULL), (val + 9223372036854775807) = (rval * 100), tuple(65535), tuple(NULL), NULL, NULL), * FROM ( SELECT dummy AS val FROM system.one ) AS s1 ANY LEFT JOIN ( SELECT toLowCardinality(toNullable(dummy)) AS rval FROM system.one ) AS s2 ON (val + 100) = (rval * 7)"

Perf shouldn't be degraded, for example I did a simple non scientific series of time on 10k runs fuzzings and observed that.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@CLAassistant
Copy link

CLAassistant commented Mar 9, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

clickhouse-ci bot commented Mar 9, 2024

This is an automatic comment. The PR descriptions does not match the template.

Please, edit it accordingly.

The error is: Changelog category is empty

Copy link

clickhouse-ci bot commented Mar 9, 2024

This is an automatic comment. The PR descriptions does not match the template.

Please, edit it accordingly.

The error is: Changelog entry required for category 'Build/Testing/Packaging Improvement'

@alexey-milovidov alexey-milovidov self-assigned this Mar 10, 2024
@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Mar 10, 2024
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-not-for-changelog This PR should not be mentioned in the changelog label Mar 10, 2024
@robot-ch-test-poll4
Copy link
Contributor

robot-ch-test-poll4 commented Mar 10, 2024

This is an automated comment for commit 453eb25 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure

@tomershafir
Copy link
Contributor Author

@alexey-milovidov can you help with CI failures here?

@alexey-milovidov
Copy link
Member

Stateless tests (asan) [1/4] — fail: 1, passed: 1554, skipped: 15

This is a benign data race in curl: curl/curl#13065

AST fuzzer (debug) — Logical error: 'Expected single dictionary argument for function.'.

This is related to a non-released feature, "Analyzer".

@alexey-milovidov alexey-milovidov merged commit edde598 into ClickHouse:master Mar 10, 2024
227 of 232 checks passed
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 10, 2024
@tomershafir tomershafir deleted the query-fuzzer-replace-rand-when-full branch March 14, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants