-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some clang-tidy fixes #61150
Merged
Merged
Some clang-tidy fixes #61150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The string representation will be deprecated at some point: https://reviews.llvm.org/D147876
robot-ch-test-poll4
added
pr-not-for-changelog
This PR should not be mentioned in the changelog
submodule changed
At least one submodule changed in this PR.
labels
Mar 11, 2024
This is an automated comment for commit 3486b4a with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
evillique
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pr-not-for-changelog
This PR should not be mentioned in the changelog
pr-synced-to-cloud
The PR is synced to the cloud repo
submodule changed
At least one submodule changed in this PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #60733, clang-tidy 17 is now the minimum, we can use YAML list syntax in .clang-tidy (string syntax will be deprecated at some point, https://reviews.llvm.org/D147876).
EDIT: Also fixes or suppresses clang-tidy warnings in headers.
EDIT EDIT: also changes
#pragma GCC diagnostic
to#pragma clang diagnostic
.Changelog category (leave one):