Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky 02949_ttl_group_by_bug #61183

Merged

Conversation

hanfei1991
Copy link
Member

close #60627
it only fails when the inserted data falls to different partitions, which makes no sense if we wanna check the order.

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-ch-test-poll3 robot-ch-test-poll3 added pr-ci pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud labels Mar 11, 2024
@robot-ch-test-poll3
Copy link
Contributor

robot-ch-test-poll3 commented Mar 11, 2024

This is an automated comment for commit fd68fed with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests❌ failure
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure

@SmitaRKulkarni SmitaRKulkarni self-assigned this Mar 12, 2024
@hanfei1991 hanfei1991 merged commit 74bdd2a into ClickHouse:master Mar 12, 2024
213 of 224 checks passed
@hanfei1991 hanfei1991 deleted the hanfei/fix_02949_ttl_group_by_bug branch March 12, 2024 10:20
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 12, 2024
robot-ch-test-poll4 added a commit that referenced this pull request Mar 12, 2024
…e11cd7a0fc7f58708e0b10a81273fc

Cherry pick #61183 to 23.12: fix flaky 02949_ttl_group_by_bug
robot-ch-test-poll4 added a commit that referenced this pull request Mar 12, 2024
…11cd7a0fc7f58708e0b10a81273fc

Cherry pick #61183 to 24.1: fix flaky 02949_ttl_group_by_bug
robot-ch-test-poll4 added a commit that referenced this pull request Mar 12, 2024
…11cd7a0fc7f58708e0b10a81273fc

Cherry pick #61183 to 24.2: fix flaky 02949_ttl_group_by_bug
robot-ch-test-poll3 added a commit that referenced this pull request Mar 12, 2024
Backport #61183 to 23.12: fix flaky 02949_ttl_group_by_bug
robot-ch-test-poll3 added a commit that referenced this pull request Mar 12, 2024
Backport #61183 to 24.2: fix flaky 02949_ttl_group_by_bug
@robot-ch-test-poll robot-ch-test-poll added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Mar 15, 2024
Algunenano added a commit that referenced this pull request Apr 26, 2024
Backport #61183 to 24.1: fix flaky 02949_ttl_group_by_bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud pr-ci pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky 02949_ttl_group_by_bug
5 participants