Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves varPop and varSamp docs. Adds ...Stable alternative function docs. #61202

Merged
merged 4 commits into from
Mar 14, 2024

Conversation

johnnymatthews
Copy link
Contributor

Changelog category (leave one):

  • Documentation (changelog entry is not required)

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Closes ClickHouse/clickhouse-docs#2036.

@johnnymatthews johnnymatthews changed the title Docs/adds var xyz stable Improves varPop and varSamp docs. Adds ...Stable alternative function docs. Mar 11, 2024
@robot-clickhouse robot-clickhouse added the pr-documentation Documentation PRs for the specific code PR label Mar 11, 2024
@robot-clickhouse
Copy link
Member

robot-clickhouse commented Mar 11, 2024

This is an automated comment for commit ff97652 with description of existing statuses. It's updated for the latest CI running

⏳ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending

@johnnymatthews johnnymatthews marked this pull request as ready for review March 12, 2024 16:49
@qoega qoega added the can be tested Allows running workflows for external contributors label Mar 13, 2024
@serxa serxa self-assigned this Mar 14, 2024
@serxa serxa merged commit 8bc7dc4 into master Mar 14, 2024
84 of 86 checks passed
@serxa serxa deleted the docs/adds-var-xyz-stable branch March 14, 2024 10:02
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 14, 2024
@kssenii
Copy link
Member

kssenii commented Mar 14, 2024

This PR broke docs check
https://s3.amazonaws.com/clickhouse-test-reports/60024/b538e94acf484f6ced49ce1a135f7db8665becad/docs_check/run.log

Exhaustive list of all broken links found:

- On source page path = /docs/en/sql-reference/aggregate-functions/reference/varpop:
   -> linking to ../syntax#syntax-string-literal (resolved as: /docs/en/sql-reference/aggregate-functions/syntax)
   -> linking to ../syntax#syntax-expressions (resolved as: /docs/en/sql-reference/aggregate-functions/syntax)

- On source page path = /docs/en/sql-reference/aggregate-functions/reference/varsamp:
   -> linking to ../syntax#syntax-expressions (resolved as: /docs/en/sql-reference/aggregate-functions/syntax)

@kssenii kssenii mentioned this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-documentation Documentation PRs for the specific code PR pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document varXYZ functions.
6 participants