Fix has() function with Nullable column
#61249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation didn't check for `null_map` when the given argument was not `Null`. This commit adds the missing check. Fixes ClickHouse#60214
yariks5s
added
the
can be tested
robot-ch-test-poll4
added
the
pr-improvement
|
This is an automated comment for commit 9da0360 with description of existing statuses. It's updated for the latest CI running ⏳ Click here to open a full report in a separate page Successful checks
|
yariks5s
reviewed
Mar 12, 2024
Comment on lines
1
to
7
| DROP TABLE IF EXISTS 00662_has_nullable; | ||
| CREATE TABLE 00662_has_nullable(a Nullable(UInt64)) ENGINE = Memory; | ||
|
|
||
| INSERT INTO 00662_has_nullable VALUES (1), (Null); | ||
| SELECT a, has([0, 1], a) FROM 00662_has_nullable; | ||
|
|
||
| DROP TABLE 00662_has_nullable; |
There was a problem hiding this comment.
Would be also good to add more tests cases (more values in nullable table, put nullable arguments as left/both arguments in has() function.
There was a problem hiding this comment.
@yariks5s also JFYI the cases you described actually exist in https://github.com/ClickHouse/ClickHouse/blob/master/tests/queries/0_stateless/00662_array_has_nullable.sql
I was thinking about expanding it instead of writing the new file, but that test didn't have any table creation, hence I decided to create a new one.
yariks5s
approved these changes
Mar 13, 2024
robot-clickhouse-ci-1
added
the
pr-synced-to-cloud
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation didn't check for
null_mapwhen the given argument was notNull. This commit adds the missing check.Fixes #60214
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix
has()function withNullablecolumn (fixes #60214)Documentation entry for user-facing changes