-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash in arrayPartialReverseSort #61539
Fix crash in arrayPartialReverseSort #61539
Conversation
This is an automated comment for commit 4c27287 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
@@ -46,7 +46,10 @@ ColumnPtr ArraySortImpl<positive, is_partial>::execute( | |||
ErrorCodes::LOGICAL_ERROR, | |||
"Expected fixed arguments to get the limit for partial array sort" | |||
); | |||
return fixed_arguments[0].column.get()->getUInt(0); | |||
|
|||
/// During dryRun the input column might be empty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What exactly do you mean by 'dryRun' here? (when do we do it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IExecutableFunction::executeDryRunImpl. AFAIK (but don't take my word on it) it's used during query analysis to do validation before execution.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Documentation entry for user-facing changes
Closes #61261